Use standard property alias machinery in contour(). #30433
+20
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Aug 15, 2025
lib/matplotlib/contour.py
Outdated
Comment on lines
675
to
676
| raise TypeError( | ||
| "ContourSet.__init__() got an unexpected keyword argument 'color'") |
lib/matplotlib/contour.py
Outdated
| rasterized=kwargs.pop("rasterized", False), | ||
| ) | ||
| self.set(edgecolor="none") | ||
| self.set(**kwargs) # Let user-set values override defaults. |
There was a problem hiding this comment.
This is on both sides of the if (though without the comment later), so can move both outside?
Note that 'color(s)' remains special-cased because the ContourSet constructor needs to do a fair bit of special wrangling for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that 'color(s)' remains special-cased because the ContourSet constructor needs to do a fair bit of special wrangling for it.
Closes #1963.
PR summary
PR checklist