-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Update Colorizer/ColorizingArtist to work with MultiNorm #30511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
77bc51a
to
9044189
Compare
9b9aaf3
to
525314e
Compare
Thank you for the feedback @QuLogic and apologies for my sloppy mistakes :) |
improved testing for colorizer+multinorm Apply suggestions from code review Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com> updates based on feedback from @QuLogic
525314e
to
23fb63c
Compare
lib/matplotlib/colorizer.py
Outdated
dt = np.dtype('float64, float64') | ||
else: | ||
dt = np.dtype('float32, float32') | ||
reconstructed = np.ma.frombuffer(data.data, dtype=dt).reshape(data.shape) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use a view to get this, instead of poking at the internal data buffer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, the following appears to work for regular arrays, but not masked arrays
reconstructed = np.ma.array(data.view(dt))
So the issue with masked arrays is that when the dtype is chnaged from 'comlex128' to 'float64, float64' the shape of the mask changes, so we cannot do data.view(dt)
on masked data.
To support both masked and not-masked input data, we can do:
reconstructed = np.ma.array(np.asarray(data).view(dt))
To me, this looks like an improvement over poking the internal data buffer
The mask is in either case addressed in the lines following this:
if np.ma.is_masked(data):
for descriptor in dt.descr:
reconstructed[descriptor[0]][data.mask] = np.ma.masked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're already in a isinstance(data, np.ndarray)
, would it make more sense to do np.ma.getdata
instead of np.asarray
, which at first glance looks superfluous?
This PR continues the work of #28658 and #28454, #29876, aiming to close #14168. (Feature request: Bivariate colormapping)
This PR allows Colorizer and ColorizingArtist to work with
MultiNorm
andBivarColormap
andMultivarColormap
i.e. this PR will allow:
Features not included in this PR:
axes.imshow(...)
,axes.pcolor(...), and
axes.pcolormesh(...)`PR checklist