Update Colorizer/ColorizingArtist to work with MultiNorm #30511
+478
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77bc51a to
9044189
Compare
QuLogic
reviewed
Sep 4, 2025
lib/matplotlib/tests/test_colors.py
Outdated
Comment on lines
2101
to
2102
| data = [[0, 0], [1, 1]] | ||
| mdata = mcolorizer._ensure_multivariate_data(data, 2) |
There was a problem hiding this comment.
This is 2x2, which makes it unclear which dimension you are checking or if it's checking the right one. Same for all below. Better not to be square.
There was a problem hiding this comment.
👍 changed to data = [[0, 0, 0], [1, 1, 1]]
9b9aaf3 to
525314e
Compare
|
Thank you for the feedback @QuLogic and apologies for my sloppy mistakes :) |
improved testing for colorizer+multinorm Apply suggestions from code review Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com> updates based on feedback from @QuLogic
525314e to
23fb63c
Compare
This was referenced Sep 8, 2025
QuLogic
reviewed
Sep 9, 2025
Comment on lines
+831
to
+832
|
|
||
| return cm.colormaps[cmap_name] |
There was a problem hiding this comment.
Still can't run after the raise.
| if isinstance(cmap, types): | ||
| return cmap | ||
|
|
||
| cmap_name = cmap if cmap is not None else mpl.rcParams["image.cmap"] |
lib/matplotlib/tests/test_colors.py
Outdated
Comment on lines
2101
to
2102
| data = [[0, 0], [1, 1]] | ||
| mdata = mcolorizer._ensure_multivariate_data(data, 2) |
Comment on lines
+224
to
+227
| if not in_init and self.norm.n_components != cmap_obj.n_variates: | ||
| raise ValueError(f"The colormap {cmap} does not support " | ||
| f"{self.norm.n_components} variates as required by " | ||
| f"the {type(self.norm)} on this Colorizer") |
| dt = np.dtype('float64, float64') | ||
| else: | ||
| dt = np.dtype('float32, float32') | ||
| reconstructed = np.ma.frombuffer(data.data, dtype=dt).reshape(data.shape) |
There was a problem hiding this comment.
Can you use a view to get this, instead of poking at the internal data buffer?
There was a problem hiding this comment.
Good point, the following appears to work for regular arrays, but nor masked arrays
reconstructed = data.view(dt)I'll see if I can get a solution with view working for masked arrays as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the work of #28658 and #28454, #29876, aiming to close #14168. (Feature request: Bivariate colormapping)
This PR allows Colorizer and ColorizingArtist to work with
MultiNormandBivarColormapandMultivarColormapi.e. this PR will allow:
Features not included in this PR:
axes.imshow(...),axes.pcolor(...), andaxes.pcolormesh(...)`PR checklist