FIX str.decode in python2.6 does not take keyword arguments [backport to 1.4.x] #3850
Conversation
|
Can you also take out the 'be lenient ...' comment from the line above? |
| @@ -216,7 +216,7 @@ def _parse(self): | |||
| # The spec calls this an ASCII format; in Python 2.x we could | |||
| # just treat the strings and names as opaque bytes but let's | |||
| # turn them into proper Unicode, and be lenient in case of high bytes. | |||
| convert = lambda x: x.decode('ascii', errors='replace') | |||
| convert = lambda x: x.decode('ascii') | |||
There was a problem hiding this comment.
https://docs.python.org/2/library/stdtypes.html Seems to suggest that the problem is the keyword, not the error handling. I think this can be changed to x.decode('ascii', 'replace')
There was a problem hiding this comment.
https://docs.python.org/2/library/stdtypes.html#str.decode <-should be this link
|
I'll fix that ASAP, but I've got code running with mpl, so I can't test in the next 10 to 12 hours. |
|
Can we leave the "lenient" comment in. It explains why having "replace" rather than just "ascii" is important. |
|
Sorry, should have nuked the comment I left as it makes sense if the On Mon, Dec 1, 2014, 10:41 Michael Droettboom notifications@github.com
|
|
Added 0b5aae2 which return |
|
cherry-picked as 5876c02 |
No description provided.