Skip to content

Build docs on Python 3.5 #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Oct 28, 2015

I really can't take any credit for this one-line change to turn this on. There has already been a great deal of heavy lifting over many months to get this working, esp. @jenshnielsen. Thanks, everyone!

@jenshnielsen
Copy link
Member

This fails because #5292 hasn't been merged back into master from 1.5.x

@mdboom
Copy link
Member Author

mdboom commented Oct 28, 2015

Ok. I'll do the merge.

@jenshnielsen
Copy link
Member

Linkchecker is not python 3 compatible 😞

@mdboom
Copy link
Member Author

mdboom commented Oct 28, 2015

Bummer. Since linkchecker doesn't actually have to run in the same Python as the docs build, though, I wonder if we could just install it from the Debian package. I might as well try that here.

@mdboom
Copy link
Member Author

mdboom commented Oct 28, 2015

It seems linkchecker is not in the Travis APT installable whitelist. It's been requested, I think it just needs a human from Travis to manually verify that it's safe: travis-ci/apt-package-safelist#1187

We could try to install and run linkchecker in the Python 2.7 install alongside building the docs in 3.5, but that could get hairy...

@tacaswell
Copy link
Member

If we used conda we could just make two envs.....

It looks like linkchecker is making progress on python3 compatibility on their master branch, probably not worth the effort though.

@jenshnielsen
Copy link
Member

We can do that with virtualenv too if we want to something like

deactivate
source ~/virtualenv/python2.7/bin/activate
pip install linkchecker

But I don't know how brittle that will be.

@jenshnielsen
Copy link
Member

Closed since #5797 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants