-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Build docs on Python 3.5 #5338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build docs on Python 3.5 #5338
Conversation
This fails because #5292 hasn't been merged back into master from 1.5.x |
Ok. I'll do the merge. |
b322274
to
4b144cc
Compare
Linkchecker is not python 3 compatible 😞 |
Bummer. Since linkchecker doesn't actually have to run in the same Python as the docs build, though, I wonder if we could just install it from the Debian package. I might as well try that here. |
It seems We could try to install and run linkchecker in the Python 2.7 install alongside building the docs in 3.5, but that could get hairy... |
If we used conda we could just make two envs..... It looks like linkchecker is making progress on python3 compatibility on their master branch, probably not worth the effort though. |
We can do that with virtualenv too if we want to something like deactivate
source ~/virtualenv/python2.7/bin/activate
pip install linkchecker But I don't know how brittle that will be. |
Closed since #5797 is merged |
I really can't take any credit for this one-line change to turn this on. There has already been a great deal of heavy lifting over many months to get this working, esp. @jenshnielsen. Thanks, everyone!