-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
TST: add a test for tilde in tempfile for the PS backend #5958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
import os | ||
import os.path | ||
|
||
dirpath = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this set to anything else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe this should be tempdir
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that should have been tempdir
, so that if that is set, it will remove in the finally...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done (amended and force pushed)
The PS uses latex in some cases (usetex=True) and latex does not like to be called with dirnames with ~ in it (reserved char). The Fix for that was in matplotlib#5928, this is just a testcase to test for the fix.
b74d3ab
to
df9204b
Compare
TST: add a test for tilde in tempfile for the PS backend
TST: add a test for tilde in tempfile for the PS backend
backported to 1.5.x as a25bcbf |
TST: add a test for tilde in tempfile for the PS backend
The PS uses latex in some cases (usetex=True) and latex does not like to be called with dirnames with ~ in it (reserved char). The Fix for that was in #5928, this is just a testcase to test for the fix.