Skip to content

TST: add a test for tilde in tempfile for the PS backend #5958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2016

Conversation

jankatins
Copy link
Contributor

The PS uses latex in some cases (usetex=True) and latex does not like to be called with dirnames with ~ in it (reserved char). The Fix for that was in #5928, this is just a testcase to test for the fix.

@QuLogic QuLogic added this to the 1.5.2 (Critical bug fix release) milestone Feb 2, 2016
import os
import os.path

dirpath = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this set to anything else?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe this should be tempdir.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that should have been tempdir, so that if that is set, it will remove in the finally...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done (amended and force pushed)

The PS uses latex in some cases (usetex=True) and latex does not
like to be called with dirnames with ~ in it (reserved char).
The Fix for that was in
matplotlib#5928, this is just a
testcase to test for the fix.
tacaswell added a commit that referenced this pull request Feb 3, 2016
TST: add a test for tilde in tempfile for the PS backend
@tacaswell tacaswell merged commit 1fa2697 into matplotlib:master Feb 3, 2016
tacaswell added a commit that referenced this pull request Feb 3, 2016
TST: add a test for tilde in tempfile for the PS backend
@tacaswell
Copy link
Member

backported to 1.5.x as a25bcbf

tacaswell added a commit to tacaswell/matplotlib that referenced this pull request May 22, 2016
TST: add a test for tilde in tempfile for the PS backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants