TST: add a test for tilde in tempfile for the PS backend #5958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import os | ||
| import os.path | ||
|
|
||
| dirpath = None |
There was a problem hiding this comment.
Where is this set to anything else?
There was a problem hiding this comment.
I think maybe this should be tempdir.
There was a problem hiding this comment.
yes, that should have been tempdir, so that if that is set, it will remove in the finally...
There was a problem hiding this comment.
done (amended and force pushed)
The PS uses latex in some cases (usetex=True) and latex does not like to be called with dirnames with ~ in it (reserved char). The Fix for that was in #5928, this is just a testcase to test for the fix.
b74d3ab to
df9204b
Compare
tacaswell
added a commit
that referenced
this pull request
Feb 3, 2016
TST: add a test for tilde in tempfile for the PS backend
tacaswell
added a commit
that referenced
this pull request
Feb 3, 2016
TST: add a test for tilde in tempfile for the PS backend
|
backported to 1.5.x as a25bcbf |
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
May 22, 2016
TST: add a test for tilde in tempfile for the PS backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PS uses latex in some cases (usetex=True) and latex does not like to be called with dirnames with ~ in it (reserved char). The Fix for that was in #5928, this is just a testcase to test for the fix.