Use new defaults more often in examples #5997
Conversation
|
why |
|
Those plots have -2/2 as limits, so I thought it might fit a bit better, though since the data has no real meaning, I suppose it's just as good either way. |
|
Ah, then using diverging map seems like the right thing to do. |
| @@ -172,7 +172,7 @@ def stack_hist(ax, stacked_data, sty_cycle, bottoms=None, | |||
| hist_func = partial(np.histogram, bins=edges) | |||
|
|
|||
| # set up style cycles | |||
| color_cycle = cycler('facecolor', 'rgbm') | |||
| color_cycle = cycler('facecolor', plt.rcParams['axes.prop_cycle'][:4]) | |||
There was a problem hiding this comment.
This will break if there is more than one key in the default prop_cycle
There was a problem hiding this comment.
Yes, good point; I suppose I'll have to iterate, unless the by_key thing you mentioned in the other comment is released.
There was a problem hiding this comment.
I am currently working on sorting out what needs to be done for a cycler release, hopefully I can get this done today 
.
There was a problem hiding this comment.
With a new cycler release, we can also fix the key normalization problem
for property cycles via change_key()
On Sun, Feb 14, 2016 at 3:01 PM, Thomas A Caswell notifications@github.com
wrote:
In examples/api/filled_step.py
#5997 (comment):@@ -172,7 +172,7 @@ def stack_hist(ax, stacked_data, sty_cycle, bottoms=None,
hist_func = partial(np.histogram, bins=edges)set up style cycles
-color_cycle = cycler('facecolor', 'rgbm')
+color_cycle = cycler('facecolor', plt.rcParams['axes.prop_cycle'][:4])I am currently working on sorting out what needs to be done for a cycler
release, hopefully I can get this done today [image:—
Reply to this email directly or view it on GitHub
https://github.com/matplotlib/matplotlib/pull/5997/files#r52847857.
|
I did cycler 0.10.0 last night, I think we can bump the minimum version for 2.x+ |
The axes props demo is trying to set the grid style to something non-default, but the default is now solid, so it appears to do nothing. Similarly, the "thick" lines in the axhspan don't appear so thick any more now that the default line style is a little thicker.
Otherwise, without the edge lines, it's just a couple of error bars in the middle of the longer bar.
82fabeb to
2164154
Compare
|
Great, looks like a rebase picked up the new version. |
Use new defaults more often in examples
I've been through almost all the examples, and tried to add either the default style, or something similar to it. Or in some cases, change some examples to actually be non-default, since the settings they use are now the new default.
This PR + #5995 should make most of the documentation more consistent.