Make sure that loose version is used for version check #6558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is on 1.5.x but not on 2.x seems like something went wrong in the merge
|
I thought we did not need to fail this test on 2.x? The thing that went wrong is I intentionally did not port it, sorry. The test file is missing the import now. |
|
Sorry this is a confusing mess. There are two tests failing with Numpy >= 1.11 which we skip on 1.5.x But the issue in I fixed the import issue, sorry Tracked in #5950 |
|
@jenshnielsen Thanks for cleaning up the mess I made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is on 1.5.x but not on 2.x. Its eems like something went wrong in the merge from 1.5.x to 2. Probably because the matching fix to another test needed to be dropped.