Skip to content

Make sure that loose version is used for version check #6558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2016
Merged

Make sure that loose version is used for version check #6558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a32cb09
Make sure that loose version is used for version check
jenshnielsen Jun 8, 2016
b27e978
Remember to import LooseVersion
jenshnielsen Jun 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/matplotlib/tests/test_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import six
from six.moves import xrange
from itertools import chain
from distutils.version import LooseVersion
import io

from nose.tools import assert_equal, assert_raises, assert_false, assert_true
Expand Down Expand Up @@ -88,7 +89,7 @@ def test_formatter_ticker():

@image_comparison(baseline_images=["formatter_large_small"])
def test_formatter_large_small():
if tuple(map(int, np.__version__.split('.'))) >= (1, 11, 0):
if LooseVersion(np.__version__) >= LooseVersion('1.11.0'):
raise KnownFailureTest("Fall out from a fixed numpy bug")
# github issue #617, pull #619
fig, ax = plt.subplots(1)
Expand Down