-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
better freetype version checking #6803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
continuation of #6403, to fix the commit message log - as an alternative |
"Expect many image comparison failures below.") | ||
"Expect many image comparison failures below. " | ||
"Expected freetype version {0}. " | ||
"Found freetype version {1}." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space after period.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was also not the case in the original, so I don't see the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was not the case in the original? The original had spaces between sentences. This one is missing a space between two sentences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, don't worry. We won't ask you to rebase/squash for this. It was only to clean out a messy revision history. Fixing one little thing doesn't need a rebase/squash in my opinion.
All the appveyor jobs are still queued. I am going to go ahead and just merge this. |
better freetype version checking
backported to v2.x as ca5324c |
@prinsherbert, thank you for bearing with us through the review process. |
Thank you for merging! |
No description provided.