Skip to content

better freetype version checking #6803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2016

Conversation

prhbrt
Copy link

@prhbrt prhbrt commented Jul 20, 2016

No description provided.

@prhbrt
Copy link
Author

prhbrt commented Jul 20, 2016

continuation of #6403, to fix the commit message log - as an alternative git rebase.

"Expect many image comparison failures below.")
"Expect many image comparison failures below. "
"Expected freetype version {0}. "
"Found freetype version {1}."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space after period.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also not the case in the original, so I don't see the problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was not the case in the original? The original had spaces between sentences. This one is missing a space between two sentences.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, don't worry. We won't ask you to rebase/squash for this. It was only to clean out a messy revision history. Fixing one little thing doesn't need a rebase/squash in my opinion.

@WeatherGod
Copy link
Member

All the appveyor jobs are still queued. I am going to go ahead and just merge this.

@WeatherGod WeatherGod merged commit 96003f9 into matplotlib:master Jul 20, 2016
WeatherGod added a commit that referenced this pull request Jul 20, 2016
@WeatherGod
Copy link
Member

backported to v2.x as ca5324c

@WeatherGod
Copy link
Member

@prinsherbert, thank you for bearing with us through the review process.

@prhbrt
Copy link
Author

prhbrt commented Jul 20, 2016

Thank you for merging!

@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants