REV: remove default formatter on log minor ticks #7000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts part of matplotlib#5161 original commit merged to master as 947e6eb the merge was backported to v2.x as fb45c4a
|
This was causing these to be in the docs:
The issues are the overstriking, the wiggly baseline, and the difficulty in telling which tick the intermediate labels apply to. The smarter formatter is still there and can be used, but is disabled by default. |
|
This is certainly an improvement, and I am willing to merge as-is, but it feels like we are papering over some deeper issues. Do we have issues filed detailing the wiggly baseline? Also, I feel that there is too much blank space between the tick labels now, but at least they aren't overlapping anymore, right? |
efiring
added a commit
to efiring/matplotlib
that referenced
this pull request
Nov 7, 2016
This partly restores the functionality that was added in PR matplotlib#5161 and partly removed in matplotlib#7000. The "partly" is because now the labeling of minor log ticks is turned on only when numdecs (the axis range in powers of the log base) is less than or equal to one, rather than 3. This also fixes a bug that was causing double labeling with a base of 2; minor ticks were coinciding with major ticks, and both were being labeled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts part of #5161
original commit merged to master as 947e6eb
the merge was backported to v2.x as fb45c4a