Skip to content

BUG: fix autoscale_view with log scale and margins #7410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2016
Merged

BUG: fix autoscale_view with log scale and margins #7410

merged 2 commits into from
Nov 5, 2016

Conversation

efiring
Copy link
Member

@efiring efiring commented Nov 5, 2016

LogLocator.view_limits was always clipping vmin to minpos;
now it sets vmin to minpos only if vmin <= 0.

@efiring
BUG: fix autoscale_view with log scale and margins
2edf1e3 
LogLocator.view_limits was always clipping vmin to minpos;
now it sets vmin to minpos only if vmin <= 0.
@efiring efiring added this to the 2.0 (style change major release) milestone Nov 5, 2016
@efiring
Copy link
Member Author

efiring commented Nov 5, 2016

There are many failed tests because the test baseline images show the effects of the bug. I am fixing the images.

@efiring efiring added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Nov 5, 2016
@efiring efiring changed the title BUG: fix autoscale_view with log scale and margins [MRG] BUG: fix autoscale_view with log scale and margins Nov 5, 2016
@NelleV
Copy link
Member

NelleV commented Nov 5, 2016

Thanks! This looks good.

@NelleV NelleV changed the title [MRG] BUG: fix autoscale_view with log scale and margins [MRG+1] BUG: fix autoscale_view with log scale and margins Nov 5, 2016
@NelleV
Copy link
Member

NelleV commented Nov 5, 2016

Was there a ticket opened for this bug? It sorts of rings a bell…

@efiring
Copy link
Member Author

efiring commented Nov 5, 2016

Closes #6643.

@efiring efiring mentioned this pull request Nov 5, 2016
Merged
QuLogic
QuLogic approved these changes Nov 5, 2016
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what minpos is supposed to represent, but all the test images certainly look better.

@efiring
Copy link
Member Author

efiring commented Nov 5, 2016

@Qlogic, minpos is the minimum positive value in the data. It is used to handle log scales applied to data that might include zero or negative values.

@NelleV NelleV merged commit cb21ba7 into matplotlib:v2.x Nov 5, 2016
@NelleV
Copy link
Member

NelleV commented Nov 5, 2016

Thanks @efiring !

@efiring efiring deleted the log_locator_vmin branch November 5, 2016 22:17
@tacaswell
Copy link
Member

wow, that is a major improvement!

@efiring
Copy link
Member Author

efiring commented Nov 8, 2016

@anntzer pointed out the error in his writeup of #6643.

@anntzer anntzer mentioned this pull request Nov 8, 2016
Closed
@Kojoley Kojoley changed the title [MRG+1] BUG: fix autoscale_view with log scale and margins BUG: fix autoscale_view with log scale and margins Nov 8, 2016
This was referenced Nov 11, 2016
Closed
Closed
@QuLogic QuLogic mentioned this pull request Dec 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelleV NelleV NelleV approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@efiring @NelleV @tacaswell @QuLogic