Enh color names #7639

tacaswell · 2016-12-18T21:36:22Z

This supersedes https://github.com/matplotlib/matplotlib/pull/7343/files

This is the result of an email conversation with Maureen Stone from Tableau.

We still need a link target for the default style changes to tableau.

The naming prefix 'T10' might need a bit more thought as these colors are actually from an older version of Tableau. They have since updated their colors and we should not name our selves into a corner.

@trpham would you be offended if I squashed your commits into 1?

QuLogic · 2016-12-18T21:39:48Z

Still hoping for a 'grey' variant; not sure what to do about the prefix.

efiring · 2016-12-18T21:49:30Z

doc/users/dflt_style_changes.rst

+<https://github.com/vega/vega/wiki/Scales#scale-range-literals>`__ and
+`d3
+<https://github.com/d3/d3-3.x-api-reference/blob/master/Ordinal-Scales.md#category10>`__
+originally developed at Tableau.


Add link here to the Tableau blog post describing their development?

I offered to let Tableau pick where this link goes, still waiting to hear back from them.

Will work on getting you that link soon.

NelleV · 2016-12-19T08:35:18Z

If we go with T10, it implies that we will either have another namespace for the vega 20 colorscheme, or that we won't add those colors.
I'd rather go with the prefix tableau.

NelleV · 2016-12-19T14:39:09Z

This is set to the milestone 2.0. Is that on purpose?
If so, do you mind if I also work on this to get this out of the door ASAP?

tacaswell · 2016-12-19T14:44:33Z

Yes, milestone is intentional.

I would have claimed this is low risk, but I seem to have broken everything...

NelleV · 2016-12-19T15:16:20Z

It is because the color name cannot contain capital letters with our current code.

NelleV · 2016-12-19T15:17:19Z

(culprit being colors.py l.156, that checks that the lower case of the colorname provided is in a dictionnary).

mcstone · 2016-12-21T01:49:56Z

Just confirming that we at Tableau are quite happy to have you folks include any of our colors as long as they are properly credited (using tableau as the prefix would make that clear, of course, though it is a bit long). The Classic Tableau 10 and 20 have been in use for a while, are the ones currently under discussion. But, I have a new set of default colors that got designed according to this article, as well as many more palettes.

NelleV · 2016-12-21T23:51:20Z

@tacaswell should we change the prefix to tableau ? it is longer to type, but I think it is worth having an explicit name (T10 is a bit obscure). It also allows us to have only one namespace for the 10 and 20 color schemes and in addition fixes the capitalization issue.

mcstone · 2016-12-22T01:13:15Z

Another prefix to consider is tc (for Tableau Color). Putting the explanation in a comment next to the definition would both provide the mnemonic and give credit.

NelleV · 2016-12-22T17:53:45Z

I still prefer the explicit name "tableau". It is longer to type, but easier to remember.
(I think I am going to loose this battle :p)

NelleV · 2016-12-22T20:12:43Z

doc/users/dflt_style_changes.rst

@@ -32,8 +32,13 @@ Colors in default property cycle
 --------------------------------

 The colors in the default property cycle have been changed from
-``['b', 'g', 'r', 'c', 'm', 'y', 'k']`` to the `Vega category10 palette
-<https://github.com/vega/vega/wiki/Scales#scale-range-literals>`__
+``['b', 'g', 'r', 'c', 'm', 'y', 'k']`` to the ``__ to the category10


I think there is a problem here.

Thanks. I swear I know how to delete text....

QuLogic

Typos.

QuLogic · 2016-12-22T22:33:40Z

doc/users/colors.rst

+* one of ``{'tc:blue', 'tc:orange', 'tc:green',
+  'tc:red', 'tc:purple', 'tc:brown', 'tc:pink',
+  'tc:gray', 'tc:olive', 'tc:cyan'}`` which are the Tableau Colors from the
+  'T10' categorical palate (which is the default color cycle).


QuLogic · 2016-12-22T22:33:49Z

doc/users/dflt_style_changes.rst

-``['b', 'g', 'r', 'c', 'm', 'y', 'k']`` to the `Vega category10 palette
-<https://github.com/vega/vega/wiki/Scales#scale-range-literals>`__
+``['b', 'g', 'r', 'c', 'm', 'y', 'k']`` to the category10
+color palete used by `Vega


NelleV · 2016-12-30T09:16:18Z

@tacaswell What are the next steps on this PR? I don't think we quite reached a consensus on the color palette namespace.

stonebig · 2017-01-05T18:46:10Z

is this the last thing blocking Matplotlib-2.0 ? could it be postponed to 2.0.1 ? (looks non critical)

tacaswell · 2017-01-05T20:20:56Z

color names are part of the API.

dopplershift · 2017-01-09T20:26:33Z

👍 to tc prefix--tableau is a nightmare for spelling with our predominantly english-speaking audience.

codecov-io · 2017-01-10T02:44:36Z

Current coverage is 62.10% (diff: 100%)

Merging #7639 into master will increase coverage by <.01%

@@             master      #7639   diff @@
==========================================
  Files           174        174          
  Lines         56051      56057     +6   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          34808      34814     +6   
  Misses        21243      21243          
  Partials          0          0

Powered by Codecov. Last update 3b9a92d...2810da3

anntzer · 2017-01-10T06:45:09Z

+1 for tc as well.

phobson

This looks good to me, but I can't for the life of me figure out why the coverage dropped so much.

tacaswell · 2017-01-11T16:37:02Z

@phobson the whole coverage report looks off, it says this PR adds 65 files.

NelleV · 2017-01-13T19:10:37Z

I still don't like "tc" as a prefix. It is very obscure. Someone suggested to me "tab", as it is both short, and avoids the "eau" that english speakers struggle with remembering.

Are we interested in exploring other possible prefixes?

NelleV · 2017-01-13T19:10:53Z

(Else this looks ready to be merged)

dopplershift · 2017-01-13T19:28:31Z

"tab" works for me.

phobson · 2017-01-13T19:28:40Z

@NelleV I think this ship has sailed :/.

My personal preference would be tableau, but given that the palette's designer has blessed tc, that's probably the best option.

QuLogic

Still want a 'grey', but this really should move along...

anntzer · 2017-01-16T05:17:18Z

@QuLogic @tacaswell re: grey
Isn't this just a matter of adding it in the T10_COLORS dictionary? If so I'd +1 adding it right now...

tacaswell · 2017-01-16T06:13:30Z

I am wary of adding extra colors given that we are adopting an existing palette.

We already have 'grey' and 'gray' the un-prefixed colors and floats as strings get mapped to shades of gray.

import matplotlib.colors as mc
print(mc.to_hex(mc.to_rgb('gray'))) 
# '#808080'

QuLogic · 2017-01-16T06:21:57Z

They are, as with the unprefixed colours, expected to be the same colour, not some new value.

QuLogic · 2017-01-16T06:28:02Z

And in the unprefixed set, we have darkgray/darkgrey, darkslategray/darkslategrey, dimgray/dimgrey, gray/grey, lightgray/lightgrey, lightslategray/lightslategrey, slategray/slategrey with every pair equal to each other, so I don't see why this new palette can't have the same aliasing.

Interestingly, the xkcd palette only spells it 'grey'.

tacaswell · 2017-01-16T17:21:39Z

@QuLogic Sorry, completely missed that we already had 'tc:gray' and was responding to something un-related to what you were asking 🐑

My only concern about including two spellings of 'gray' in the palette is that users may want to use list(matplotlib.colors.T10_COLORS.items()) as a color cycle. Of the dictionaries we currently have, it is the only one small enough to usable for that, so this a completely made up use case, but one I could see growing in the future.

anntzer · 2017-01-16T17:24:02Z

That would require (in practice) the dict being an OrderedDict, which may not be a bad idea in itself...

tacaswell · 2017-01-16T17:39:02Z

@anntzer That is also a good point and idea!

anntzer · 2017-01-16T17:40:42Z

(but then you need to know where to put the other spelling of grey/gray in the ordereddict)

tacaswell · 2017-01-16T17:48:30Z

Looking at the work you did in colors.py with the _colors_full_mapping we can do the gray/grey normalization there and leave TABLEAU_COLORS and XKCD_COLORS spelled as the source material spells them. I am not 100% that the spelling it tableau is 'cannonical', might want to normalize it to 'grey' to match xkcd (which makes the duplication code in colors.py a bit more uniform).

tacaswell · 2017-01-16T18:03:38Z

To try and summarize all of the prefix discussions:

tableau
- pro: very explicit
- con: long, any future varients would be even longer
- con: anglophiles have a hard time spelling it
tc
- pro: short
- pro: suggested by @mcstone from tableau
- con: some what obscure to source of naming
- con: 'c' is redundant as we all know we are talking about colors
- con(?): my initials
t
- same as tc, but even shorter!
tab
- pro: short
- pro: much less obscure than 'tc'
- con: collision with head namespace of the tab key? (that is the best I can come up with)

and I think I have written my self into preferring 'tab'

dopplershift · 2017-01-16T18:17:54Z

Because of the initials aspect, at the very minimum we need a comment saying explicitly what tc stands for.

efiring · 2017-01-16T18:45:06Z

On 2017/01/16 8:03 AM, Thomas A Caswell wrote: and I think I have written my self into preferring 'tab'

"tab" is fine with me.

- change naming to tab - credit Tableau for developing the colors - support both spellings of grey an Tableau&xkcd colors - add tests of grey/gray equivalence and tableau order - use more explicit internal names + add comment

NelleV · 2017-01-16T20:21:22Z

LGTM 👍

Enh color names

tacaswell · 2017-01-16T20:34:49Z

backported to v2.x as 4e1df0b

tacaswell added this to the 2.0 (style change major release) milestone Dec 18, 2016

efiring reviewed Dec 18, 2016

View reviewed changes

NelleV self-assigned this Dec 21, 2016

NelleV reviewed Dec 22, 2016

View reviewed changes

QuLogic reviewed Dec 22, 2016

View reviewed changes

anntzer mentioned this pull request Jan 8, 2017

Adding names to the color in the new Vega10 color cycle #7343

Closed

phobson approved these changes Jan 11, 2017

View reviewed changes

QuLogic approved these changes Jan 15, 2017

View reviewed changes

tacaswell force-pushed the enh_color_names branch from e0c6dcf to 5942a64 Compare January 16, 2017 17:37

trpham and others added 2 commits January 16, 2017 15:12

Adding names to the color in the new Vega10 color cycle

44d7127

API/DOC: change color name to tab from vega

317eaff

- change naming to tab - credit Tableau for developing the colors - support both spellings of grey an Tableau&xkcd colors - add tests of grey/gray equivalence and tableau order - use more explicit internal names + add comment

tacaswell force-pushed the enh_color_names branch from 2810da3 to 317eaff Compare January 16, 2017 20:14

NelleV approved these changes Jan 16, 2017

View reviewed changes

efiring merged commit 7555a7a into matplotlib:master Jan 16, 2017

tacaswell deleted the enh_color_names branch January 16, 2017 20:32

tacaswell pushed a commit that referenced this pull request Jan 16, 2017

Merge pull request #7639 from tacaswell/enh_color_names

4e1df0b

Enh color names

anntzer mentioned this pull request Feb 19, 2017

Please add Vega in perception documentation #8073

Closed

Perseudonymous mentioned this pull request Sep 30, 2017

New color blind-friendly color cycle #9255

Merged

6 tasks

Uh oh!

Enh color names #7639

Enh color names #7639

Uh oh!

Conversation

tacaswell commented Dec 18, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QuLogic commented Dec 18, 2016

Uh oh!

efiring Dec 18, 2016

Choose a reason for hiding this comment

Uh oh!

tacaswell Dec 18, 2016

Choose a reason for hiding this comment

Uh oh!

mcstone Dec 21, 2016

Choose a reason for hiding this comment

Uh oh!

NelleV commented Dec 19, 2016

Uh oh!

NelleV commented Dec 19, 2016

Uh oh!

tacaswell commented Dec 19, 2016

Uh oh!

NelleV commented Dec 19, 2016

Uh oh!

NelleV commented Dec 19, 2016

Uh oh!

mcstone commented Dec 21, 2016

Uh oh!

NelleV commented Dec 21, 2016

Uh oh!

mcstone commented Dec 22, 2016

Uh oh!

NelleV commented Dec 22, 2016

Uh oh!

NelleV Dec 22, 2016

Choose a reason for hiding this comment

Uh oh!

tacaswell Dec 22, 2016

Choose a reason for hiding this comment

Uh oh!

QuLogic left a comment

Choose a reason for hiding this comment

Uh oh!

QuLogic Dec 22, 2016

Choose a reason for hiding this comment

Uh oh!

QuLogic Dec 22, 2016

Choose a reason for hiding this comment

Uh oh!

NelleV commented Dec 30, 2016

Uh oh!

stonebig commented Jan 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tacaswell commented Jan 5, 2017

Uh oh!

dopplershift commented Jan 9, 2017

Uh oh!

codecov-io commented Jan 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 62.10% (diff: 100%)

Uh oh!

anntzer commented Jan 10, 2017

Uh oh!

phobson left a comment

Choose a reason for hiding this comment

Uh oh!

tacaswell commented Jan 11, 2017

Uh oh!

NelleV commented Jan 13, 2017

Uh oh!

NelleV commented Jan 13, 2017

Uh oh!

dopplershift commented Jan 13, 2017

Uh oh!

phobson commented Jan 13, 2017

Uh oh!

tacaswell commented Dec 18, 2016 •

edited

Loading

stonebig commented Jan 5, 2017 •

edited

Loading

codecov-io commented Jan 10, 2017 •

edited

Loading

anntzer commented Jan 16, 2017 •

edited

Loading