New color blind-friendly color cycle #9255

Perseudonymous · 2017-09-30T14:52:02Z

PR Summary

There is only one color blind-friendly color cycle included in matplotlib at present (not counting the grayscale cycle). This pull request adds another defined from the color blind 10 cycle from Tableau. This uses more colors than the seaborn-colorblind cycle.

I assume the use of the name is fine given the discussion in this pull request: #7639

PR Checklist

Most of this

N/A Has Pytest style unit tests
N/A Code is PEP 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

tacaswell · 2017-09-30T17:52:07Z

attn @mcstone to verify that the name is still ok in this case.

mcstone · 2017-10-02T14:50:55Z

It's fine

…

Sent from my iPhone On Oct 2, 2017, at 7:29 AM, Thomas A Caswell <notifications@github.com<mailto:notifications@github.com>> wrote: attn @mcstone<https://github.com/mcstone> to verify that the name is still ok in this case. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#9255 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AF77YrVKee5lIyjviYgRuZVLFsRgtYoXks5snn_TgaJpZM4PplPo>.

jklymak · 2017-10-02T17:27:57Z

Probably beyond the scope of this PR:

... are style sheets the only way to define color cycles? It seems a big step from the seaborn styles to defining just the color cycle.

I ask because I was going to suggest an example, but I see that all the styles are plotted automagically, so I guess its not needed. OTOH, if everyone who wants a custom color cycle writes a new style, that page will get quite crowded...

WeatherGod · 2017-10-02T17:40:21Z

Nope, you can define all sorts of things through the prop_cycle rc param programmatically. We are working to streamline this API, but this example should give you a basic idea: https://matplotlib.org/examples/color/color_cycle_demo.html

…

On Mon, Oct 2, 2017 at 1:28 PM, Jody Klymak ***@***.***> wrote: Probably beyond the scope of this PR: ... are style sheets the only way to define color cycles? It seems a big step from the seaborn styles to defining just the color cycle. I ask because I was going to suggest an example, but I see that all the styles are plotted automagically, so I guess its not needed. OTOH, if everyone who wants a custom color cycle writes a new style, that page will get quite crowded... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9255 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARy-PiKUAEzZmGGagsos1OTmwcS0qUbks5soR0egaJpZM4PplPo> .

jklymak · 2017-10-02T19:18:46Z

@WeatherGod I think I knew about that. But I mean is there somewhere in the library to define a bunch of colorcycles by name like there is to define a bunch of colormaps? i.e. something like lib/_cc.py or lib/_colorcycles.py?

WeatherGod · 2017-10-02T19:25:55Z

Ah, I see. No, we don't have that. Partly because it has to integrate in with the property cycle. You could have some style files that define just a property cycle for a given color cycle, but you wouldn't be able to compose that with any other property cycles (let's say I want to also modify linestyles as well).

…

On Mon, Oct 2, 2017 at 3:18 PM, Jody Klymak ***@***.***> wrote: @WeatherGod <https://github.com/weathergod> I think I knew about that. But I mean is there somewhere in the library to define a bunch of colorcycles by name like there is to define a bunch of colormaps? i.e. something like lib/_cc.py or lib/_colorcycles.py? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9255 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARy-KY32CURSh9KWMlCZ2DCdW9TUgeYks5soTcagaJpZM4PplPo> .

jklymak

A couple of suggested changes to make it clear to folks that this is done via matplotlib styles.

jklymak · 2017-10-02T19:35:18Z

doc/users/next_whats_new/new_color_cycle.rst

@@ -0,0 +1,4 @@
+New colorblind-friendly color cycle


Suggest "New style defining colorblind-friendly color cycle"

jklymak · 2017-10-02T19:39:48Z

doc/users/next_whats_new/new_color_cycle.rst

+New colorblind-friendly color cycle
+===================================
+
+A new color cycle has been added, tableau-colorblind10, to provide another option for colorblind-friendly plots.


Suggest "A new style has been adding defining a color cycle tableu_colorblind10 ..."

Suggest a link to: :ref:sphx_glr_tutorials_introductory_customizing.py (Umm, I think I referenced that correctly)

jklymak · 2017-10-02T19:42:11Z

@WeatherGod Thanks! I looked more carefully at the existing files in mpl_data/stylelib , and quite a few of them are just color cycles like this PR. I guess this makes sense since you can combine style sheets, and I'm sure its not worth adding another layer of complexity.

jklymak · 2017-10-18T20:00:03Z

@EJEP I took the liberty of making very small changes to your whats new entry.

This isn't building because of a change to doc/conf.py.

dstansby · 2017-11-04T17:24:41Z

This needs a rebase on to current master to make the CircleCI build work

There is currently only one colorblind friendly color cycle in the included style sheets. This adds another - the colorblind 10 palette from Tableau.

dstansby · 2017-11-11T10:00:14Z

I think it would be really good to get this in, so I've rebased on to master to hopefully make all the tests pass.

tacaswell added this to the 2.2 (next next feature release) milestone Sep 30, 2017

tacaswell approved these changes Oct 2, 2017

View reviewed changes

jklymak reviewed Oct 2, 2017

View reviewed changes

jklymak mentioned this pull request Oct 17, 2017

Color blind-friendly default color cycle #9460

Open

Perseudonymous and others added 3 commits November 11, 2017 09:58

Add tableau colorblind 10 palette

9a2e7a2

There is currently only one colorblind friendly color cycle in the included style sheets. This adds another - the colorblind 10 palette from Tableau.

Add what's new file for new color cycle

34114de

Mild edit to next_whats_new

25ea897

dstansby force-pushed the tableau-colorblind10 branch from cb6703b to 25ea897 Compare November 11, 2017 09:59

jklymak approved these changes Nov 11, 2017

View reviewed changes

WeatherGod merged commit 49c6f50 into matplotlib:master Nov 13, 2017

QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018

wronk mentioned this pull request Apr 9, 2018

Color blind safe colors for object-detection/segmentation labels developmentseed/label-maker#64

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

New color blind-friendly color cycle #9255

New color blind-friendly color cycle #9255

Uh oh!

Perseudonymous commented Sep 30, 2017

Uh oh!

tacaswell commented Sep 30, 2017

Uh oh!

mcstone commented Oct 2, 2017 via email

Uh oh!

jklymak commented Oct 2, 2017

Uh oh!

WeatherGod commented Oct 2, 2017 via email

Uh oh!

jklymak commented Oct 2, 2017

Uh oh!

WeatherGod commented Oct 2, 2017 via email

Uh oh!

jklymak left a comment

Uh oh!

jklymak Oct 2, 2017 •

edited

Loading

Uh oh!

jklymak Oct 2, 2017 •

edited

Loading

Uh oh!

jklymak commented Oct 2, 2017

Uh oh!

jklymak commented Oct 18, 2017 •

edited

Loading

Uh oh!

dstansby commented Nov 4, 2017

Uh oh!

dstansby commented Nov 11, 2017

Uh oh!

Uh oh!

Uh oh!

New color blind-friendly color cycle #9255

New color blind-friendly color cycle #9255

Uh oh!

Conversation

Perseudonymous commented Sep 30, 2017

PR Summary

PR Checklist

Uh oh!

tacaswell commented Sep 30, 2017

Uh oh!

mcstone commented Oct 2, 2017 via email

Uh oh!

jklymak commented Oct 2, 2017

Uh oh!

WeatherGod commented Oct 2, 2017 via email

Uh oh!

jklymak commented Oct 2, 2017

Uh oh!

WeatherGod commented Oct 2, 2017 via email

Uh oh!

jklymak left a comment

Choose a reason for hiding this comment

Uh oh!

jklymak Oct 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jklymak Oct 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jklymak commented Oct 2, 2017

Uh oh!

jklymak commented Oct 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dstansby commented Nov 4, 2017

Uh oh!

dstansby commented Nov 11, 2017

Uh oh!

Uh oh!

jklymak Oct 2, 2017 •

edited

Loading

jklymak Oct 2, 2017 •

edited

Loading

jklymak commented Oct 18, 2017 •

edited

Loading