Convert font/text tests to pytest #7872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 IMO, the sooner we get these in, the better |
|
WRT parametrizing the comparison decorator, I just had a thought that we'd eventually be moving to |
|
@QuLogic while I'm by no means an expert, FWIW I have not had any luck parametrizing pytest-mpl comparison tests. |
1bd576e to
a7476f2
Compare
a7476f2 to
e82db62
Compare
|
Is this one still a work in progress? |
|
Just rebased; comments in the first post are optimizations that can wait for another PR. |
jkseppan
added a commit
that referenced
this pull request
Jan 23, 2017
Merge pull request #7872: Convert font/text tests to pytest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is partially complete, but I have not been able to fully convert the mathtext/mathfont tests to use parametrization. The attempt at that is here, but of course it doesn't quite work yet. I don't think there's any way to parametrize the decorator, though maybe I've missed it. Any ideas @Kojoley?