-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Cleanup visual_tests and disable browser opening #8018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
50f8c59
Template-ize visual_tests.py.
QuLogic 20b018a
Pass missing variable to format string.
QuLogic 3891566
Simplify dictionary access in visual_tests.py.
QuLogic 7cd4cc9
PEP8 visual_tests.py.
QuLogic ccca1f3
Sort results in visual test HTML.
QuLogic a89d7d2
Don't start a browser for visual tests on CI.
QuLogic ef20a3b
Move visual_tests into tools.
QuLogic a4dcd54
Add tools directory to pep8.
QuLogic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ | |
| """ | ||
|
|
||
| import matplotlib | ||
| matplotlib.use('agg') | ||
| matplotlib.use('agg') # noqa | ||
|
|
||
| import six | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,137 @@ | ||
| #!/usr/bin/env python | ||
| # | ||
| # This builds a html page of all images from the image comparison tests | ||
| # and opens that page in the browser. | ||
| # | ||
| # $ python tools/visualize_tests.py | ||
| # | ||
|
|
||
| import argparse | ||
| import os | ||
| from collections import defaultdict | ||
|
|
||
|
|
||
| html_template = """<html><head><style media="screen" type="text/css"> | ||
| img{{ | ||
| width:100%; | ||
| max-width:800px; | ||
| }} | ||
| </style> | ||
| </head><body> | ||
| {failed} | ||
| {body} | ||
| </body></html> | ||
| """ | ||
|
|
||
| subdir_template = """<h2>{subdir}</h2><table> | ||
| <thead><td>name</td><td>actual</td><td>expected</td><td>diff</td></thead> | ||
| {rows} | ||
| </table> | ||
| """ | ||
|
|
||
| failed_template = """<h2>Only Failed</h2><table> | ||
| <thead><td>name</td><td>actual</td><td>expected</td><td>diff</td></thead> | ||
| {rows} | ||
| </table> | ||
| """ | ||
|
|
||
| row_template = ('<tr>' | ||
| '<td>{0}{1}</td>' | ||
| '<td>{2}</td>' | ||
| '<td><a href="{3}"><img src="{3}"></a></td>' | ||
| '<td>{4}</td>' | ||
| '</tr>') | ||
|
|
||
| linked_image_template = '<a href="{0}"><img src="{0}"></a>' | ||
|
|
||
|
|
||
| def run(show_browser=True): | ||
| """ | ||
| Build a website for visual comparison | ||
| """ | ||
| image_dir = "result_images" | ||
| _subdirs = (name | ||
| for name in os.listdir(image_dir) | ||
| if os.path.isdir(os.path.join(image_dir, name))) | ||
|
|
||
| failed_rows = [] | ||
| body_sections = [] | ||
| for subdir in sorted(_subdirs): | ||
| if subdir == "test_compare_images": | ||
| # These are the images which test the image comparison functions. | ||
| continue | ||
|
|
||
| pictures = defaultdict(dict) | ||
| for file in os.listdir(os.path.join(image_dir, subdir)): | ||
| if os.path.isdir(os.path.join(image_dir, subdir, file)): | ||
| continue | ||
| fn, fext = os.path.splitext(file) | ||
| if fext != ".png": | ||
| continue | ||
| # Always use / for URLs. | ||
| if "-failed-diff" in fn: | ||
| pictures[fn[:-12]]["f"] = "/".join((subdir, file)) | ||
| elif "-expected" in fn: | ||
| pictures[fn[:-9]]["e"] = "/".join((subdir, file)) | ||
| else: | ||
| pictures[fn]["c"] = "/".join((subdir, file)) | ||
|
|
||
| subdir_rows = [] | ||
| for name, test in sorted(pictures.items()): | ||
| expected_image = test.get('e', '') | ||
| actual_image = test.get('c', '') | ||
|
|
||
| if 'f' in test: | ||
| # A real failure in the image generation, resulting in | ||
| # different images. | ||
| status = " (failed)" | ||
| failed = '<a href="{0}">diff</a>'.format(test['f']) | ||
| current = linked_image_template.format(actual_image) | ||
| failed_rows.append(row_template.format(name, "", current, | ||
| expected_image, failed)) | ||
| elif 'c' not in test: | ||
| # A failure in the test, resulting in no current image | ||
| status = " (failed)" | ||
| failed = '--' | ||
| current = '(Failure in test, no image produced)' | ||
| failed_rows.append(row_template.format(name, "", current, | ||
| expected_image, failed)) | ||
| else: | ||
| status = " (passed)" | ||
| failed = '--' | ||
| current = linked_image_template.format(actual_image) | ||
|
|
||
| subdir_rows.append(row_template.format(name, status, current, | ||
| expected_image, failed)) | ||
|
|
||
| body_sections.append( | ||
| subdir_template.format(subdir=subdir, rows='\n'.join(subdir_rows))) | ||
|
|
||
| if failed_rows: | ||
| failed = failed_template.format(rows='\n'.join(failed_rows)) | ||
| else: | ||
| failed = '' | ||
| body = ''.join(body_sections) | ||
| html = html_template.format(failed=failed, body=body) | ||
| index = os.path.join(image_dir, "index.html") | ||
| with open(index, "w") as f: | ||
| f.write(html) | ||
|
|
||
| show_message = not show_browser | ||
| if show_browser: | ||
| try: | ||
| import webbrowser | ||
| webbrowser.open(index) | ||
| except: | ||
| show_message = True | ||
|
|
||
| if show_message: | ||
| print("Open {} in a browser for a visual comparison.".format(index)) | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument('--no-browser', action='store_true', | ||
| help="Don't show browser after creating index page.") | ||
| args = parser.parse_args() | ||
| run(show_browser=not args.no_browser) |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the comment mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skip flake8/pep8 issues with this line. (This line causes a warning about imports not at the top of the file.)