Cleanup visual_tests and disable browser opening #8018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps this script should be moved next to |
b975717 to
1114840
Compare
|
Done. |
1114840 to
b5a55a1
Compare
This makes the result a bit more reproducable and comparable.
Travis may or may not have a browser installed, but AppVeyor definitely does, so this saves a tiny bit of processing power per run.
b5a55a1 to
a4dcd54
Compare
|
Rebased to fix conflicts. |
NelleV
reviewed
Feb 23, 2017
| @@ -11,7 +11,7 @@ | |||
| """ | |||
|
|
|||
| import matplotlib | |||
| matplotlib.use('agg') | |||
| matplotlib.use('agg') # noqa | |||
There was a problem hiding this comment.
Skip flake8/pep8 issues with this line. (This line causes a warning about imports not at the top of the file.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intermixing HTML and code makes this file very difficult to read (for me, at least), so change it to use some simple template forms.
Also, don't automatically open the browser on CI because AppVeyor has one installed and it's a waste to open it.