-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Mep12 ticks and spines #8212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mep12 ticks and spines #8212
Conversation
ax2.plot(x, y) | ||
|
||
# Only draw spine between the y-ticks | ||
ax2.spines['left'].set_bounds(-1, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I learned something...
Please backport to 2.0.0-doc |
@@ -26,7 +30,18 @@ | |||
ax1.yaxis.set_ticks_position('left') | |||
ax1.xaxis.set_ticks_position('bottom') | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for two empty lines? (there's only one between ax0 and ax1)
============= | ||
Tick locators | ||
============= | ||
|
||
Show the different tick locators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a dot.
====== | ||
|
||
This demo compares : | ||
- normal axes, with spines on all four sides |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add dots (or commas) at the end of each item.
Spines | ||
====== | ||
|
||
This demo compares : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no space before the colon (English typography :-))
I fixed the blank spaces/lines issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just being finicky...
This demo compares: | ||
- normal axes, with spines on all four sides; | ||
- an axes with spines only on the left and bottom; | ||
- an axes using custom bounds to limit the extent of the spine; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not at the end of the last item...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a side note, when it starts being that nitpicky, it is much faster to fix it yourself before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I didn't even bother doing it on my computer: I just did it through the github API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I didn't know I could do it directly there... good point.
Thanks. |
Backported to |
I've merged two examples and wrote documentation for a bunch of others.
refs #7206