Skip to content

Mep12 ticks and spines #8212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2017
Merged

Mep12 ticks and spines #8212

merged 4 commits into from
Mar 7, 2017

Conversation

NelleV
Copy link
Member

@NelleV NelleV commented Mar 7, 2017

I've merged two examples and wrote documentation for a bunch of others.

refs #7206

@NelleV NelleV changed the title Mep12 ticks and spines [MRG] Mep12 ticks and spines Mar 7, 2017
@QuLogic QuLogic changed the title [MRG] Mep12 ticks and spines [MRG+1] Mep12 ticks and spines Mar 7, 2017
ax2.plot(x, y)

# Only draw spine between the y-ticks
ax2.spines['left'].set_bounds(-1, 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I learned something...

@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Mar 7, 2017
@tacaswell
Copy link
Member

Please backport to 2.0.0-doc

@NelleV NelleV changed the title [MRG+1] Mep12 ticks and spines [MRG+2] Mep12 ticks and spines Mar 7, 2017
@@ -26,7 +30,18 @@
ax1.yaxis.set_ticks_position('left')
ax1.xaxis.set_ticks_position('bottom')


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for two empty lines? (there's only one between ax0 and ax1)

=============
Tick locators
=============

Show the different tick locators
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a dot.

======

This demo compares :
- normal axes, with spines on all four sides
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add dots (or commas) at the end of each item.

Spines
======

This demo compares :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no space before the colon (English typography :-))

@NelleV
Copy link
Member Author

NelleV commented Mar 7, 2017

I fixed the blank spaces/lines issues.

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just being finicky...

This demo compares:
- normal axes, with spines on all four sides;
- an axes with spines only on the left and bottom;
- an axes using custom bounds to limit the extent of the spine;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not at the end of the last item...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, when it starts being that nitpicky, it is much faster to fix it yourself before merging.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I didn't even bother doing it on my computer: I just did it through the github API.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't know I could do it directly there... good point.

@anntzer anntzer merged commit b2137d7 into matplotlib:master Mar 7, 2017
@anntzer
Copy link
Contributor

anntzer commented Mar 7, 2017

Thanks.

@anntzer anntzer changed the title [MRG+2] Mep12 ticks and spines Mep12 ticks and spines Mar 7, 2017
@dstansby dstansby added the MEP: MEP12 gallery and examples improvements label Mar 25, 2017
dstansby pushed a commit that referenced this pull request Mar 25, 2017
@dstansby
Copy link
Member

Backported to 2.0.0-doc via. 6750f68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation MEP: MEP12 gallery and examples improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants