MAINT moved some maintenance and helper python scripts to tools/ #8276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
damn… that's what it is to work offline :) |
|
I'll rebase once #8018 is merged |
tacaswell
approved these changes
Mar 12, 2017
QuLogic
requested changes
Mar 13, 2017
tools/boilerplate.py
Outdated
| @@ -365,7 +365,7 @@ def format_value(value): | |||
|
|
|||
|
|
|||
| def build_pyplot(): | |||
| pyplot_path = os.path.join(os.path.dirname(__file__), 'lib', | |||
| pyplot_path = os.path.join("../", os.path.dirname(__file__), 'lib', | |||
There was a problem hiding this comment.
This doesn't look quite right; if __file__ is an absolute path, then it'll ignore the .. part. Less importantly, there shouldn't be a trailing / since it's using os.path.join.
It should probably be os.pardir and come after the dirname.
|
Indeed there was a problem: the code run fine but wasn't updating the file. |
dstansby
approved these changes
Mar 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our root folder is currently a bit messy and overwhelming.
In an attempt to clean it up a bit and make it more clear for contributors what files does what, I attempted to consolidate the organization a bit.
This pull requests moves some of our maintenance and helper python scripts to our tools folder.
Note that license.py only works on python 2.