-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC added titles to the rest of the 3D plots #8306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of minor things. Otherwise, it looks good to me.
examples/mplot3d/lines3d_demo.py
Outdated
@@ -1,4 +1,8 @@ | |||
''' | |||
========================= | |||
3D parametric curve in 3D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"in 3D" is a bit redundant.
@@ -1,4 +1,8 @@ | |||
""" | |||
================= | |||
2D and 3D suplots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: "suplots" --> "subplots"
Thanks for the review @WeatherGod . I've fixed the two titles. |
Appveyor is definitely broken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor things. LGTM.
examples/mplot3d/contour3d_demo.py
Outdated
@@ -1,5 +1,7 @@ | |||
''' | |||
=================================================== | |||
Demonstrates plotting contour (level) curves in 3D. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove period? (was done on the next one)
Custom hillshading in a 3D surface plot | ||
======================================= | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra blank line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider this approval number 4...
This PR should finish up the migration of the axes3D plots to sphinx-gallery. The titles aren't great, but this should help finish up the migration quickly.