Skip to content

DOC added titles to the rest of the 3D plots #8306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2017
Merged

DOC added titles to the rest of the 3D plots #8306

merged 1 commit into from
Mar 19, 2017

Conversation

NelleV
Copy link
Member

@NelleV NelleV commented Mar 16, 2017

This PR should finish up the migration of the axes3D plots to sphinx-gallery. The titles aren't great, but this should help finish up the migration quickly.

@NelleV NelleV changed the title DOC added titles to the rest of the 3D plots [MRG+1] DOC added titles to the rest of the 3D plots Mar 16, 2017
@NelleV NelleV added the MEP: MEP12 gallery and examples improvements label Mar 16, 2017
@NelleV NelleV changed the title [MRG+1] DOC added titles to the rest of the 3D plots [MRG] DOC added titles to the rest of the 3D plots Mar 16, 2017
Copy link
Member

@WeatherGod WeatherGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of minor things. Otherwise, it looks good to me.

@@ -1,4 +1,8 @@
'''
=========================
3D parametric curve in 3D
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in 3D" is a bit redundant.

@@ -1,4 +1,8 @@
"""
=================
2D and 3D suplots
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "suplots" --> "subplots"

@NelleV
Copy link
Member Author

NelleV commented Mar 16, 2017

Thanks for the review @WeatherGod . I've fixed the two titles.

@NelleV NelleV changed the title [MRG] DOC added titles to the rest of the 3D plots [MRG+1] DOC added titles to the rest of the 3D plots Mar 16, 2017
@phobson
Copy link
Member

phobson commented Mar 16, 2017

Appveyor is definitely broken.
Travis failure looks spurious, but I'll restart the one failing travis build just to be sure.

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things. LGTM.

@@ -1,5 +1,7 @@
'''
===================================================
Demonstrates plotting contour (level) curves in 3D.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove period? (was done on the next one)

Custom hillshading in a 3D surface plot
=======================================


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra blank line.

@NelleV NelleV changed the title [MRG+1] DOC added titles to the rest of the 3D plots [MRG+3] DOC added titles to the rest of the 3D plots Mar 19, 2017
@dstansby dstansby changed the title [MRG+3] DOC added titles to the rest of the 3D plots DOC added titles to the rest of the 3D plots Mar 19, 2017
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this approval number 4...

@dstansby dstansby self-assigned this Mar 19, 2017
@dstansby dstansby merged commit f238c58 into matplotlib:master Mar 19, 2017
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Mar 19, 2017
@NelleV NelleV deleted the MEP_3d branch March 19, 2017 21:14
@dstansby dstansby removed their assignment Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation MEP: MEP12 gallery and examples improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants