Parameterize test_fill_between and test_fill_betweenx #8729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
reviewed
Jun 7, 2017
| (np.arange(0.0, 2, 0.02), 3, np.zeros((2, 2))) | ||
| ] | ||
| ) | ||
| def test_fill_betweenx_input(y, x1, x2): | ||
| fig = plt.figure() | ||
| ax = fig.add_subplot(211) |
There was a problem hiding this comment.
Anyone got any idea why this line is here? Looks pointless to me...
There was a problem hiding this comment.
Are you sure this is the line you meant to comment on? How else would you plot without an Axes?
There was a problem hiding this comment.
🤦♂️ I thought the previous line was plt.subplots (which I'm far too used too). Still not sure why it's called with 211 instead of 111, but doesn't make a difference either way.
dstansby
approved these changes
Jun 7, 2017
QuLogic
requested changes
Jun 7, 2017
lib/matplotlib/tests/test_axes.py
Outdated
| (np.arange(0.0, 2, 0.02), np.zeros((2, 2)), 3), | ||
| (np.arange(0.0, 2, 0.02), 3, np.zeros((2, 2))) | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Please add some ids to this call; you can use the unique parts of the original functions names, probably.
There was a problem hiding this comment.
Thanks for pointing that out. Added.
lib/matplotlib/tests/test_axes.py
Outdated
| (np.arange(0.0, 2, 0.02), np.zeros((2, 2)), 3), | ||
| (np.arange(0.0, 2, 0.02), 3, np.zeros((2, 2))) | ||
| ] | ||
| ) |
dstansby
approved these changes
Jun 8, 2017
QuLogic
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parametrize test_fill_between and test_fill_betweenx and drops plot call
fixes #8698
PR Summary
PR Checklist