Made colorbar.py accept numpy array input, compatible with output fro… #8739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
previously requested changes
Jun 10, 2017
56028ea to
0e339a1
Compare
0e339a1 to
4ace2a4
Compare
|
Phew, OK, think I figured out all the rebasing. @anntzer thanks for the hand-holding. |
anntzer
reviewed
Jun 10, 2017
lib/matplotlib/colorbar.py
Outdated
| # turn parents into a list if it is not already. We do this w/ np | ||
| # because `ax=plt.subplots(1,1)` is an ndarray and is natural to | ||
| # pass to `colorbar`. | ||
| parents = np.atleast_1d(parents).ravel().tolist() |
There was a problem hiding this comment.
Actually it looks like you can drop the tolist(), a flat array should be just fine.
tacaswell
reviewed
Jun 11, 2017
lib/matplotlib/colorbar.py
Outdated
| if not isinstance(parents, (list, tuple)): | ||
| parents = [parents] | ||
| # turn parents into a list if it is not already. We do this w/ np | ||
| # because `ax=plt.subplots(1,1)` is an ndarray and is natural to |
There was a problem hiding this comment.
Picky thing, but this comment is not quite right, should should be fig, ax_arr = plt.subplots(squeeze=False) or something like that.
There was a problem hiding this comment.
"We do this because plt.subplots can return axes in an ndarray and ..."
There was a problem hiding this comment.
Picky is good. Thanks, now reads:
# turn parents into a list if it is not already. We do this w/ np
# because `plt.subplots` can return an ndarray and is natural to
# pass to `colorbar`.
parents = np.atleast_1d(parents).ravel()|
👍 modulo comment about comment. |
anntzer
approved these changes
Jun 11, 2017
|
Test failures are due to warning -> error from numpy 1.13 |
6 tasks
jklymak
added a commit
to jklymak/matplotlib
that referenced
this pull request
Jun 13, 2017
Accept a wider range of iterables for `ax`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a duplicate of #8733. Appologies to @anntzer who reviewed the previous, and suggested the fix used here.
fig.colorbar(pcm=pcm,ax=axs)can take a list of axes objects as the argument to ax. However,axs=plt.subplots(2,1)returns a numpyobject. This PR simply checks ifaxsis an object and flattens and makes the object a list. Now commands like:will take space away from all the subplots, and put a colorbar on the right of all four subplots.
PR Checklist