BUGS: in colorbar: divide-by-zero, and undesired masked array #8812
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes matplotlib#8534 (divide-by-zero warning). Also fixes a bug that became evident with matplotlib#8801, which causes pcolormesh to fail if X or Y is a masked array. Although masked arrays are not supported by pcolormesh, previously it would ignore the mask. Locators always return masked arrays, so the present commit explicitly converts to an ndarray the Locator output used by proportional colorbars.
tacaswell
approved these changes
Jun 27, 2017
|
I probably should have reviewed 👍 before merging...oh well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8534 (divide-by-zero warning).
Also fixes a bug that became evident with #8801, which causes
pcolormesh to fail if X or Y is a masked array. Although masked
arrays are not supported by pcolormesh, previously it would ignore
the mask. Locators always return masked arrays, so the present
commit explicitly converts to an ndarray the Locator output used
by proportional colorbars.