Skip to content

Doc yinleon rebase #8860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 15, 2017
Merged

Doc yinleon rebase #8860

merged 7 commits into from
Jul 15, 2017

Conversation

tacaswell
Copy link
Member

Rebase of #8209

attn @dstansby @choldgraf

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jul 10, 2017

This shows 4 possible projections using subplot.
Matplotlib also supports
<a href='http://matplotlib.org/basemap/'>Basemaps Toolkit</a> and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use proper rst markup instead

=================

This is an example of creating a stacked bar plot with error bars
using `plt.bar`. Note the parameters *yerr* used for error bars, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess sphinx will fail to resolve what plt.bar is but I may be wrong.

2D and 3D subplots
==================
============================================
Demonstrate the mixing of 2d and 3d subplots
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2D, 3D (see just below)

================

This is an example of plotting Edward Lorenz's 1963 "Deterministic
Nonperiodic Flow" in a 3-dimensional space using mplot3d.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link below could use proper rst markup too

Resampling Data
===============


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove blank line


Downsampling lowers the sample rate or sample size of a signal. In
this tutorial, the signal is downsampled when the plot is adjusted
through dragging and zooming.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... except that the example is completely broken (try it). It should either be fixed or removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does what it claims, but in a weird way. It always down-samples to every 5th point but also clips the data.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re worked this a bit.

It works on zoom, but not pan which seems like a bug Mpl, not in the example.

@anntzer
Copy link
Contributor

anntzer commented Jul 11, 2017

(feel free to dismiss the review when you consider the issues addressed)

Fixed target number of points instead of fixed data reduction.
@tacaswell tacaswell dismissed anntzer’s stale review July 11, 2017 03:18

All issues addressed.

@@ -4,8 +4,7 @@
===========

This is an example to show how to build cross-GUI applications using
matplotlib event handling to interact with objects on the canvas

matplotlib event handling to interact with objects on the canvas.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matplotlib --> Matplotlib

2D and 3D subplots
==================
============================================
Demonstrate the mixing of 2D and 3D subplots
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original title is more succinct and clear, but happy for it to change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps just "Mixing 2D and 3D subplots"?

"""

# a stacked bar plot with errorbars
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment seems redundant now there's a proper description at the top.

======================

This shows 4 possible projections using subplot. Matplotlib also
supports `Basemaps Toolkit <http://matplotlib.org/basemap>`_ and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https

@tacaswell
Copy link
Member Author

The scitools https gives we errors so leaving as http.

Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 if the doc build passes

@NelleV NelleV merged commit 30cdd23 into matplotlib:master Jul 15, 2017
@tacaswell tacaswell deleted the doc_yinleon_rebase branch July 15, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants