-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Doc yinleon rebase #8860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc yinleon rebase #8860
Conversation
examples/pylab_examples/geo_demo.py
Outdated
|
||
This shows 4 possible projections using subplot. | ||
Matplotlib also supports | ||
<a href='http://matplotlib.org/basemap/'>Basemaps Toolkit</a> and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use proper rst markup instead
================= | ||
|
||
This is an example of creating a stacked bar plot with error bars | ||
using `plt.bar`. Note the parameters *yerr* used for error bars, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess sphinx will fail to resolve what plt.bar
is but I may be wrong.
examples/mplot3d/mixed_subplots.py
Outdated
2D and 3D subplots | ||
================== | ||
============================================ | ||
Demonstrate the mixing of 2d and 3d subplots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2D, 3D (see just below)
examples/mplot3d/lorenz_attractor.py
Outdated
================ | ||
|
||
This is an example of plotting Edward Lorenz's 1963 "Deterministic | ||
Nonperiodic Flow" in a 3-dimensional space using mplot3d. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link below could use proper rst markup too
examples/event_handling/resample.py
Outdated
Resampling Data | ||
=============== | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove blank line
examples/event_handling/resample.py
Outdated
|
||
Downsampling lowers the sample rate or sample size of a signal. In | ||
this tutorial, the signal is downsampled when the plot is adjusted | ||
through dragging and zooming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... except that the example is completely broken (try it). It should either be fixed or removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does what it claims, but in a weird way. It always down-samples to every 5th point but also clips the data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re worked this a bit.
It works on zoom, but not pan which seems like a bug Mpl, not in the example.
(feel free to dismiss the review when you consider the issues addressed) |
Fixed target number of points instead of fixed data reduction.
@@ -4,8 +4,7 @@ | |||
=========== | |||
|
|||
This is an example to show how to build cross-GUI applications using | |||
matplotlib event handling to interact with objects on the canvas | |||
|
|||
matplotlib event handling to interact with objects on the canvas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matplotlib --> Matplotlib
examples/mplot3d/mixed_subplots.py
Outdated
2D and 3D subplots | ||
================== | ||
============================================ | ||
Demonstrate the mixing of 2D and 3D subplots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the original title is more succinct and clear, but happy for it to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps just "Mixing 2D and 3D subplots"?
""" | ||
|
||
# a stacked bar plot with errorbars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment seems redundant now there's a proper description at the top.
examples/pylab_examples/geo_demo.py
Outdated
====================== | ||
|
||
This shows 4 possible projections using subplot. Matplotlib also | ||
supports `Basemaps Toolkit <http://matplotlib.org/basemap>`_ and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https
The scitools https gives we errors so leaving as http. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 if the doc build passes
Rebase of #8209
attn @dstansby @choldgraf