Skip to content

On 2.7, run tests on oldest documented supported pytest and pytest-cov. #9317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2018
Merged

On 2.7, run tests on oldest documented supported pytest and pytest-cov. #9317

merged 1 commit into from
Jan 4, 2018
+42 −20

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 8, 2017

... to make sure that they are indeed supported.
Basically to avoid issues like like #9303.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@dstansby dstansby added this to the 2.2 (next feature release) milestone Oct 8, 2017
tacaswell
tacaswell approved these changes Oct 8, 2017
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending travis passing on the re-run (error in the qt4 tests that seemed transient).

@anntzer
Copy link
Contributor Author

anntzer commented Oct 8, 2017

Added testing of oldest versions of all deps we claim to support.

@anntzer
Copy link
Contributor Author

anntzer commented Oct 8, 2017

Well, looks like we actually don't support pytest 3.0 :-) I'll probably just bump the minimum supported version.

@tacaswell
Copy link
Member

👍 to bumping pytest version to the minimum we really do support.

@anntzer anntzer force-pushed the test-oldest-pytest branch from 26dd275 to 0f44009 Compare October 8, 2017 20:38
@anntzer
Copy link
Contributor Author

anntzer commented Oct 8, 2017

It's actually not clear at all from looking at their changelogs which version of pytest introduced the needed functionality...

@tacaswell
Copy link
Member

Just keep bumping it until it passes? #experimentalist

@anntzer anntzer force-pushed the test-oldest-pytest branch 3 times, most recently from 7e305d9 to 403dd7b Compare October 9, 2017 03:18
@anntzer
Copy link
Contributor Author

anntzer commented Oct 9, 2017

Looks like I got it now.

@QuLogic
Copy link
Member

QuLogic commented Oct 9, 2017

I don't see any error with pytest 3.0? The only failure there is brokenness on our part, which is fixed here in another PR.

@anntzer
Copy link
Contributor Author

anntzer commented Oct 9, 2017

hmmm does travis delete old logs? can't point to it anymore, but basically it was not liking the skipif in https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/tests/test_backends_interactive.py#L21

@anntzer anntzer force-pushed the test-oldest-pytest branch from 403dd7b to 37ad7ab Compare October 22, 2017 07:03
@anntzer anntzer force-pushed the test-oldest-pytest branch 2 times, most recently from 702cd01 to cf84bb5 Compare November 4, 2017 06:40
dstansby
dstansby approved these changes Dec 8, 2017
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (needs a rebase)

@anntzer anntzer force-pushed the test-oldest-pytest branch from 7b4ae79 to 34bea8c Compare December 8, 2017 17:10
@anntzer
On 2.7, run tests on oldest documented supported deps.
57c8f18 
... to make sure that they are indeed supported.

Bump to pytest>=3.1 (actually required), dateutil>⩦2.1 (dateutil==2.0
is listed on pypi but has no sdist or wheel available).
@anntzer anntzer force-pushed the test-oldest-pytest branch from 34bea8c to 57c8f18 Compare December 8, 2017 18:45
@anntzer anntzer mentioned this pull request Dec 17, 2017
Closed
6 tasks
@dstansby dstansby modified the milestones: v2.2, v2.1.2 Jan 4, 2018
@dstansby
Copy link
Member

dstansby commented Jan 4, 2018

Going to merge into master since this has two approvals, and also backport to 2.1.2 (if travis runs fine with this on 2.1.2)

@dstansby dstansby merged commit 3441571 into matplotlib:master Jan 4, 2018
@lumberbot-app
Copy link

lumberbot-app bot commented Jan 4, 2018

There seem to be a conflict, please backport manually

@anntzer anntzer deleted the test-oldest-pytest branch January 4, 2018 20:51
tacaswell pushed a commit that referenced this pull request Jan 17, 2018
@dstansby @tacaswell
Merge pull request #9317 from anntzer/test-oldest-pytest
c72d3fc 
On 2.7, run tests on oldest documented supported pytest and
pytest-cov.

Conflicts:
	.travis.yml
          - keep version from master
	setupext.py
          - keep version from v2.1.x
@tacaswell
Copy link
Member

backported to v2.1.x as c72d3fc

@tacaswell tacaswell mentioned this pull request Feb 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v2.1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @QuLogic @dstansby