Skip to content

TST: remove Python 3.5 from Appveyor [Do Not Merge] [skip travis] #9374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

TST: remove Python 3.5 from Appveyor [Do Not Merge] [skip travis] #9374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2de3b5
TST: remove Python 3.5 from Appveyor
cgohlke Oct 11, 2017
d37eb90
TST: disable faulthandler on Python 3.6.3 on Windows
cgohlke Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,6 @@ environment:
PYTHON_VERSION: "2.7"
TEST_ALL: "no"
CONDA_INSTALL_LOCN: "C:\\Miniconda-x64"
- TARGET_ARCH: "x64"
CONDA_PY: "35"
CONDA_NPY: "110"
PYTHON_VERSION: "3.5"
CONDA_INSTALL_LOCN: "C:\\Miniconda35-x64"
TEST_ALL: "no"
- TARGET_ARCH: "x64"
CONDA_PY: "36"
PYTHON_VERSION: "3.6"
Expand Down
15 changes: 9 additions & 6 deletions lib/matplotlib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1347,12 +1347,15 @@ def tk_window_focus():


def _init_tests():
try:
import faulthandler
except ImportError:
pass
else:
faulthandler.enable()
# work around https://bugs.python.org/issue31701
# faulthandler dumps 'Windows fatal exception: code 0xe06d7363'
if not (sys.platform == 'win32' and sys.version_info[:3] == (3, 6, 3)):
try:
import faulthandler
except ImportError:
pass
else:
faulthandler.enable()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this completely and enable it on travis with pytest-faulthandler.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better (optional) if you document it at http://matplotlib.org/devdocs/devel/testing.html#requirements

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It's output is not useful if you do not have debug symbols (distutils does not produce it for windows and strips for linux by default on non-debug version)
  2. faulthandler could be enabled with pytest by pytest-faulthandler module (that's what I've suggested earlier)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build would pass even without disabling faulthandler.


# The version of FreeType to install locally for running the
# tests. This must match the value in `setupext.py`
Expand Down