BLD: Fix some bugs in setupext.py
#9510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `CONDA_DEFAULT_ENV`used to determine the env location but sometimes the value was just an env name. It was fixed too.
tacaswell
approved these changes
Oct 21, 2017
anntzer
reviewed
Nov 1, 2017
setupext.py
Outdated
| @@ -151,7 +151,8 @@ def has_include_file(include_dirs, filename): | |||
| directories in `include_dirs`. | |||
| """ | |||
| if sys.platform == 'win32': | |||
| include_dirs += os.environ.get('INCLUDE', '.').split(';') | |||
| include_dirs = list(include_dirs) | |||
| include_dirs += os.environ.get('INCLUDE', '.').split(os.pathsep) | |||
There was a problem hiding this comment.
probably worth clarifying in a comment? I would have missed the point of the change if not for the commit message...
There was a problem hiding this comment.
I'm also concerned about the change from split(';') to split(os.pathsep). Those are not the same, but there's nothing indicating the rationale behind them.
There was a problem hiding this comment.
@dopplershift os.pathsep == ; on windows https://docs.python.org/2/library/os.html#os.pathsep
Visual C++ 2015 x64 Native Build Tools Command Prompt
C:\Program Files (x86)\Microsoft Visual C++ Build Tools>set INCLUDE
INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE;C:\Program Files (x86)\Windows Kits\10\include\10.0.15063.0\ucrt;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6\include\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.15063.0\shared;C:\Program Files(x86)\Windows Kits\10\include\10.0.15063.0\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.15063.0\winrt;
There was a problem hiding this comment.
Oops. 🐑 Thanks for clarifying.
The passed argument would be modified by function while it not designed to.
ae264b1 to
d527a82
Compare
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.