Set widget background color to white. #9698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Nov 6, 2017
| super(FigureCanvasQT, self).__init__(figure=figure) | ||
|
|
||
| figure._original_dpi = figure.dpi |
There was a problem hiding this comment.
Does the super chain no longer use _original_dpi?
There was a problem hiding this comment.
AFAICT the only places it is accessed are _update_figure_dpi (which is called later) and print_figure (which is irrelevant here).
There was a problem hiding this comment.
I suspect this got sorted out as part of the initial draw / re-entrant paint fix.
tacaswell
approved these changes
Nov 7, 2017
dopplershift
approved these changes
Nov 7, 2017
|
Done. Also removed _onEraseBackground from wx, which I forgot to do together with https://github.com/matplotlib/matplotlib/pull/9697/files#diff-19c3295dfd86eed49da406f5e5296055L687. |
The background color of the widget can be seen by setting a transparent
figure facecolor, e.g.
from pylab import *
rcParams["figure.facecolor"] = (0, 0, 0, 0); gca(); show()
The goal is to ultimately replace setting `savefig.transparent` by
`figure.facecolor = (0, 0, 0, 0)`.
As far as I can tell, gtk3 already defaults to a white background. Not
sure what the situation is on OSX.
6 tasks
7 tasks
|
Actually I guess the situation on gtk depends on the desktop theme; it doesn't work on a dark theme for me. A fix is at #19410. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Set widget background to white.
The background color of the widget can be seen by setting a transparent
figure facecolor, e.g.
The goal is to ultimately replace setting
savefig.transparentbyfigure.facecolor = (0, 0, 0, 0).(see #9080 for example for the slight trickiness of savefig.transparent).
As far as I can tell, gtk3 already defaults to a white background. Not
sure what the situation is on OSX.
PR Checklist