This repository was archived by the owner on Dec 3, 2019. It is now read-only.
Add AsyncObjectPool.use to combine take and giveBack #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great 👍 Gonna run some tests and merge this, thanks @dylex ! |
|
890a2f8 is a inTransaction function that wraps a function in BEGIN/COMMIT (or ROLLBACK on error), and works both for simple Connection and ConnectionPool, if you're interested in that as well. I'm not super happy about the types needed for both uses to agree. Tested manually on postgres in simple and error conditions, but not mysql at all. I'll try to get the test suite to work so I can write some tests for postgres anyway. |
|
Can you make the transaction stuff into a separate PR? I think there could be a better workflow for it. |
|
Sure. I had just pushed to my branch -- didn't realize it would automatically get added. |
mauricio
added a commit
that referenced
this pull request
Oct 31, 2013
Add AsyncObjectPool.use to combine take and giveBack
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a common use case, and as long as the provided function doesn't hold onto the provided item it should be safe. Is this reasonable? Is it sufficiently non-trivial for addition? It eliminates duplicate code in ConnectionPool.
I'm working up to writing a withTransaction-like function but want to make sure I'm on the right track.