Add Connection.inTransaction to wrap queries in a transaction block #54
Conversation
There is an unfortunate tension between the desired argument type for this function in plain Connections (=> Future[A]) and in ConnectionPools (T => Future[A]), and so it currently uses a compromise (Connection => Future[A]) which is a bit odd in the former case and too general in the latter. One option is to take this function out of Connection and put it on a new SimpleConnection trait, with a separate function on ConnectionPool.
|
Any suggestions for better approaches to this? There are many cases where transactions are necessariy, including "upsert" operations and deferred constraints for paired inserts. Most of these usually just require a chain of two or more operations within the transaction without any need for external interaction. Admittedly many of these are better handled by pl/sql functions, but it's nice to have the option. |
|
Not sure about this yet, still thinking. Gonna try to write some code using it and see how it looks. I also need to build the same functionality using MySQL. |
|
I didn't test it (or write a test for it) on mysql but the transaction syntax is the same, so it should just work as is. |
|
What is the status on this one? I could really need this functionality to be able to send multiple prepared statements in one transaction. |
|
Gonna be finally merged later today. |
Add Connection.inTransaction to wrap queries in a transaction block
There is an unfortunate tension between the desired argument type for this function in plain Connections (
=> Future[A]) and in ConnectionPools (T => Future[A]), and so it currently uses a compromise (Connection => Future[A]) which is a bit odd in the former case and too general in the latter. One option is to take this function out of Connection and put it on a new SimpleConnection trait, with a separate function on ConnectionPool.Also includes some test cases for PostgreSQLConnection.inTransaction.
(This is on top of pull request #53.)