Skip to content

ports/renesas-ra/boards/VK-RA4W1: New board. #10595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbedNoobNinja
Copy link
Contributor

@mbedNoobNinja mbedNoobNinja commented Jan 27, 2023

ports/renesas-ra/boards/VK-RA4W1: Adding new dev board
ports/renesas-ra/boards: Based on existing RA4W1 processor
ports/renesas-ra: Part of existing RA family
ports/renesas-ra/ra: Bonus 2 drivers PWM & DAC.

Tests.log

For now the bonus is enabled only for VK-RA4W1, but with minimal changes, they should work for the other too.
For a full workability compliance with the other RA bords, they definitely must be checked by someone from Renesas.(may be @TakeoTakahashi2020)

At some point a suitable test cases should appear in tests\renesas-ra:, but it draws too much effort for me (unaware how to prepare & write tests), but Renesas should know better.

@TakeoTakahashi2020
Copy link
Contributor

Thanks, @mbedNoobNinja .

  • I tried building and faced following error happend due to missing #endif in vector_data.c. I could build it by adding #endif.
...
GEN build-VK-RA4W1/genhdr/qstr.i.last
boards/VK-RA4W1/ra_gen/vector_data.c:4: error: unterminated #if
    4 | #if VECTOR_DATA_IRQ_COUNT > 0
...
  • Regarding the board directory name, @dpgeorge guided me before that "we use underscore instead of hyphen in the directory name". So it would be necessary to change it to VK_RA4W1.

@mbedNoobNinja mbedNoobNinja force-pushed the NEW_board branch 2 times, most recently from 1a7ff28 to fb0b91c Compare January 30, 2023 14:01
@mbedNoobNinja
Copy link
Contributor Author

mbedNoobNinja commented Jan 30, 2023

Hi @TakeoTakahashi2020, I changed the name of the board, as you and @dpgeorge mentioned, and fixed the file in question vector_data.c. Following the Contributor Guidelines and more specifically the commit one, they reccomend running codeformat.py beautifier before Pull request. Which I did. It turned out, that tool damages the files which need to be altered. When it replaces tabs with spaces, if there is some spaces at the begining of the row, sometimes the content after those spaces is dropped and the code breaks at compilation stage. Most of the FSP generated files's rows begins with TABs, but some spaces appeares here and there and that obveously bugs the tool. Anyway, I somehow managed to make the both happy (compiler & codeformat.py) and now VK_RA4W1 should be compilable.

@TakeoTakahashi2020
Copy link
Contributor

Hello @mbedNoobNinja, Thanks. I could build successfully for all boards including VK_RA4W1. I do not have this board, so did only build check.

I sometimes faced codeformat issues too and confirmed workflow result of Github Actions to investigate the detail.
Regarding bonus drivers, I condier to apply them for other boards in the future. As for FSP API utilizing, thanks for your comment described in source code.If possible, like to use, but some pin conflicts for FSP configuration.

@mbedNoobNinja
Copy link
Contributor Author

mbedNoobNinja commented Jan 31, 2023

Hello @TakeoTakahashi2020, Thank you for your time cheking the new board. If you tell me an address, I could send you 3 sample boards (VK-RA4W1, VK-RA6M3 & VK-RA6M5). My plans are to make micropython ports for the other 2, but I find difficulties making the MCU's family csv file (ra6m3_af.csv & ra6m5_af.csv) because they do not exist yet and I am unaware in what pin count & alt function variety they possess. (Sure, I probably can find that info in a specified mcu's datasheet, but it seems to me, it is alot of work, It must have an easy way) Could you enlighten me how to generate or create them? Can FSP help me and do that for me? If Yes, is it mandatory for the board to use FSP v2.3.0, because RA6M5 is not included in it yet, and should be newer than that used in the micropython (which is v2.3.0). All that will generate alot more work for all RA boards, if updating the FSP is needed only for the M5 !

@TakeoTakahashi2020
Copy link
Contributor

Hello @mbedNoobNinja, Thank you for additional info. I will send you an email.

@github-actions
Copy link

github-actions bot commented Feb 10, 2023

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
        rp2:    -8 -0.002% PICO

@TakeoTakahashi2020
Copy link
Contributor

Hello @mbedNoobNinja -San,

image

You can specify "VK-RA4W1" of the product name for this macro definition.

@mbedNoobNinja
Copy link
Contributor Author

mbedNoobNinja commented Feb 21, 2023

Hi @TakeoTakahashi2020 -San,
I fixed MICROPY_HW_BOARD_NAME. Should build_all_boards.sh be change in some way.

ports/renesas-ra/boards: Integration to the existing RA4W1 processor.
ports/renesas-ra: Integration to the existing RA family.
ports/renesas-ra/ra: PWM & DAC support only for the VK-RA4W1.

Signed-off-by: mbedNoobNinja <novoltage@gmail.com>
@jimmo jimmo added the board-definition New or updated board definition files. Combine with a port- label. label Oct 9, 2023
@projectgus
Copy link
Contributor

This is an automated heads-up that we've just merged a Pull Request
that removes the STATIC macro from MicroPython's C API.

See #13763

A search suggests this PR might apply the STATIC macro to some C code. If it
does, then next time you rebase the PR (or merge from master) then you should
please replace all the STATIC keywords with static.

Although this is an automated message, feel free to @-reply to me directly if
you have any questions about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board-definition New or updated board definition files. Combine with a port- label. port-renesas-ra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants