Remove old board variants #15639
Remove old board variants #15639
Conversation
|
Code size report: |
|
Thanks, this looks good.
Yes I think we should remove them. If needed, one can build it themselves using IDF v3 (and this repo checked out at the appropriate commit in the far past).
Yes, please do this as well. Please can you split this PR into two commits:
|
|
There is a PR #12937 to add WLAN and BLE support for the SAMD51 family. The WLAN variant was created for that PR, and it seems to have sneaked into the master branch. But it harndly can be built, since the remainder of the PR is missing. |
7c1ae7e to
0e0675c
Compare
|
This should be ready now @dpgeorge 👍🏻 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15639 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 163 163
Lines 21290 21290
=======================================
Hits 20956 20956
Misses 334 334 ☔ View full report in Codecov by Sentry. |
tools/autobuild/build-boards.sh
Outdated
| # the idf3 files for older releases that used to be explicitly built). | ||
| for variant in `cat $board_json | python3 -c "import json,sys; print(' '.join(v for v in json.load(sys.stdin).get('variants', {}).keys() if v != 'IDF3'))"`; do | ||
| # Query variants from board.json and build them. | ||
| for variant in `cat $board_json | python3 -c "import json,sys; print(' '.join(v for v in json.load(sys.stdin).get('variants', {}).keys()))"`; do |
There was a problem hiding this comment.
This list comprehension is simple enough that the v for v in bit can now be removed.
There was a problem hiding this comment.
Of course; fixed. 🤦🏻♂️
0e0675c to
9a79768
Compare
There is no such variant. Signed-off-by: Matt Trentini <matt.trentini@gmail.com>
IDF 3 builds are very old now (it seems like the last successful builds are from 2021), and the current IDF 5 is stable. So remove IDF 3 variants. Signed-off-by: Matt Trentini <matt.trentini@gmail.com>
9a79768 to
b704ff6
Compare
I noticed a few unusual board variants and think they should be removed.
IDF3 builds are very old now (it seems like the last successful builds are from 2021?). Can we remove them? If we want to retain the old builds for ESP32_GENERIC then we'll need to leave
ESP32_GENERIC/board.jsonintact but we should at least remove it fromUM_TINYPICO/board.jsonsince there are no IDF3 builds for that board.If we remove IDF3 entirely we could also slightly simplify build-boards.sh:61. I haven't made that change but can if we decide to remove IDF3.
Finally, I noticed a
wlanvariant forADAFRUIT_METRO_M4_EXPRESS. I believe the samd port doesn't support variants so I think this is a mistake - and appears to be causing an unnecessary build.