github/workflows: Update Ubuntu images for code size CI tasks. #15884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15884 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 164 164
Lines 21341 21341
=======================================
Hits 21036 21036
Misses 305 305 ☔ View full report in Codecov by Sentry. |
|
Code size report: |
dpgeorge
approved these changes
Sep 23, 2024
This updates the Ubuntu OS image the code size CI tasks run on, from 20.04-LTS to 22.04-LTS. This is needed because 20.04 didn't have packages that are needed to build RISC-V 32 code. Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
55a0a7b to
8a9042a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The code size calculation CI tasks were still on Ubuntu 20.04, which is a problem for #15843 as Ubuntu 20.04 does not provide the necessary packages for building RISC-V code.
Testing
The code size CI tasks completed successfully in my branch: https://github.com/agatti/micropython/actions/runs/10957423395.