Skip to content

nrf: Facilitate use of freeze manifest. #5379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

nrf: Facilitate use of freeze manifest. #5379

wants to merge 2 commits into from

Conversation

glennrub
Copy link
Contributor

@glennrub glennrub commented Dec 4, 2019

Adding FROZEN_MANIFEST to the Makefile which is set to
boards/manifest.py by default.

Adding the boards/manifest.py that will include the ports
'freeze' folder.

Adding BOARD_DIR to the Makefile which can be referenced in
boards//mpconfigboard.mk to include a board specific
manifest.

@dpgeorge
Copy link
Member

dpgeorge commented Dec 5, 2019

Looks good!

But I see that it now freezes the freeze dir by default, whereas before it needed to be explicitly enabled. This is fine, but .travis.yml will need to be updated to build mpy-cross, so Travis builds pass.

@glennrub glennrub force-pushed the nrf_frozen_manifest branch from ce59b85 to c7666fa Compare December 9, 2019 21:36
@glennrub
Copy link
Contributor Author

glennrub commented Jan 6, 2020

@dpgeorge , does it look as you would expect? I added a new commit up front of my original commit to add the mpy-cross build in travis.

@dpgeorge
Copy link
Member

dpgeorge commented Jan 7, 2020

@glennrub it looks good to me. Only I'd also suggest updating README.md to reflect the fact that freezing is done by default, ie just put scripts to freeze in freeze/, no need for a special make invocation.

@glennrub
Copy link
Contributor Author

glennrub commented Jan 7, 2020

Only I'd also suggest updating README.md to reflect the fact that freezing is done by default, ie just put scripts to freeze in freeze/, no need for a special make invocation.

Thanks, @dpgeorge , I'm glad you mentioned it. Looking a bit closer at it, it turns out that the freeze/test.py will consume about ~700 bytes. It's a bit to much on nrf51 for demo/test purpose. So, on a second thought i'll remove this auto freeze. Then it will either be a manual make invocation or set by a target board's .mk file.

Would you mind if i keep the travis patch in any case? i believe this can be useful in the future.

@glennrub glennrub force-pushed the nrf_frozen_manifest branch 2 times, most recently from 722159c to 8c89816 Compare January 7, 2020 22:04
@dpgeorge
Copy link
Member

dpgeorge commented Jan 8, 2020

Would you mind if i keep the travis patch in any case? i believe this can be useful in the future.

Yes I think it's a good idea to keep it, and maybe even to make Travis build with a frozen manifest included to test this feature.

glennrub added 2 commits June 27, 2020 13:49
@glennrub
travis: Add mpy-cross build to nrf port.
15d01b8
@glennrub
nrf: Facilitate use of freeze manifest.
d79514f 
Updating Makefile to handle FROZEN_MANIFEST.

Updating README.md with some small samples on how to use
freeze manifests.

Adding BOARD_DIR to the Makefile which can be referenced in
boards/<board>/mpconfigboard.mk to include a board specific
manifest.
@glennrub glennrub force-pushed the nrf_frozen_manifest branch from 8c89816 to d79514f Compare June 27, 2020 11:50
@glennrub glennrub mentioned this pull request Jul 23, 2020
Closed
@glennrub glennrub mentioned this pull request Jan 6, 2021
Closed
@dpgeorge
Copy link
Member

dpgeorge commented Aug 8, 2021

Merged in 990341d and 4f76f66

@dpgeorge dpgeorge closed this Aug 8, 2021
tannewt pushed a commit to tannewt/circuitpython that referenced this pull request Oct 13, 2021
@dhalbert
Merge pull request micropython#5379 from dhalbert/improve-usb_hid-Dev…
bb2dbf4 
…ice-doc

Correct and improve usb_hid.Device doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
port-nrf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glennrub @dpgeorge