Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Prototype for the Chat People Picker #244

Closed
wants to merge 28 commits into from
Closed

Prototype for the Chat People Picker #244

wants to merge 28 commits into from

Conversation

silviuaavram
Copy link
Collaborator

WIP

@codecov
Copy link

codecov bot commented Sep 19, 2018 •
edited
Loading

Codecov Report

Merging #244 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   91.67%   91.84%   +0.16%     
==========================================
  Files          63       61       -2     
  Lines        1189     1042     -147     
  Branches      153      154       +1     
==========================================
- Hits         1090      957     -133     
+ Misses         95       82      -13     
+ Partials        4        3       -1
Impacted Files Coverage Δ
src/components/Layout/Layout.tsx 94% <0%> (-4%) ⬇️
src/components/Avatar/Avatar.tsx 96.66% <0%> (-3.34%) ⬇️
src/index.ts 100% <0%> (ø) ⬆️
src/components/Text/Text.tsx 100% <0%> (ø) ⬆️
src/components/Header/Header.tsx 95% <0%> (ø) ⬆️
src/components/Popup/positioningHelper.ts 100% <0%> (ø) ⬆️
src/components/Label/Label.tsx 85% <0%> (ø) ⬆️
src/components/Button/ButtonGroup.tsx 97.29% <0%> (ø) ⬆️
src/components/Portal/Portal.tsx 100% <0%> (ø) ⬆️
src/components/RadioGroup/RadioGroupItem.tsx
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe29de9...a2cdd13. Read the comment docs.

Silviu Avram added 22 commits September 25, 2018 11:24
added the downshift library and an example
54ed7aa
improved the component and created example
54152dd
improved the styling and functionality
80c9798
removed startdust properties and improved functionality
4c520f0
fixed style bugs, fix attempt for backspace deletion but input issue
8454d37
some code improvements
a52f353
added to prototypes
c12314b
removed the people picker from components
cdebbf1
used list instead of menu
451cb62
made a style improvement on hover
090a7b3
fixed a style issue
930fbbd
fixed tabbing not working because of handled blur event
54e2668
fixed the focus and menui opening
371a812
fixed delete on backspace
3f585f0
now the listbox closes on selection
e49ad2c
improved labels and tab handler
46eb09d
renamed the component in the example
7f51a3c
used shorthand for passing attributes on input
e5b3ece
added aria hidden on the menu when is not shown
9c9ad25
relaxed the autocomplete condition for the example
8153f10
added documentation inside prototype
2219ad4
fixed styles for the input
03a6f50
@silviuaavram silviuaavram mentioned this pull request Oct 8, 2018
Closed
11 tasks
@silviuaavram
Copy link
Collaborator Author

closing as I moved work to #334

@silviuaavram silviuaavram deleted the proto/multiple-picker branch October 8, 2018 15:23
@silviuaavram silviuaavram restored the proto/multiple-picker branch October 12, 2018 11:25
@silviuaavram silviuaavram deleted the proto/multiple-picker branch October 12, 2018 12:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alinais alinais alinais requested changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@kuzhelov kuzhelov Awaiting requested review from kuzhelov

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny miroslavstastny is a code owner

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
🚧 WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silviuaavram @alinais