You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 4, 2020. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are not including test/ folder in our typescript compiler options so nothing under tests is compiled by TypeScript.
@layershifter did some research and found out the following:
We're using a Gulp's task to run jest and our watchers for JSON info files, #task. In the Jest's config we will see, that we're using ts-jest. So the main question why ts-jest compiles and runs the code silently? 👎
Solution:
The version bump was enough to get it working correctly:
I talked to @smykhailov about this as well and he suggested that we should not rely on all these custom build scripts and tools (such as gulp / grunt) for our build. Reasons:
we end up creating build scripts everywhere that are hard to understand and maintain.
custom build scripts can introduce lots of errors and bugs as this one;
custom build scripts contain duplicated work (webpack accomplishes out of the script functionality and we only need to configure it).
We should leverage more the webpack functionality for setting up our build. This might be a good time to do this since we are just kicking off an effort for creating a Stardust monorepo #433
Do we have any issue related to our build system approach and tooling? I can create an issue and copy these findings there.
@layershifter here is the RFC I had for the test folder not being compiled by typescript; we discussed it at standup today; can you provide your input in the comments?
I'm fully agree about crazy tooling, we should massively simplify them in the future.
build/gulp/tasks/dist.ts
You have updated a task in this file, in fact it will just include tests to our dist build. It's completely weird thing.
build/tsconfig.commonjs.json
We don't need to update this config because ts-jest uses the default config from root, test directory is included there.
We're using a Gulp's task to run jest and our watchers for JSON info files, #task. In the Jest's config we will see, that we're using ts-jest. So the main question why ts-jest compiles and runs the code silently? 👎
I didn't dig the issue deeply, but the version bump was enough to get it working correctly:
build/gulp/tasks/dist.ts
You have updated a task in this file, in fact it will just include tests to our dist build. It's completely weird thing.
Oh yes, fully agree I did something very weird there, I was just trying to make a point that there's something strange about tests compilation by hacking stuff. Probably I should have created an issue and not an invalid PR.
I didn't dig the issue deeply, but the version bump was enough to get it working correctly:
very nice 💯 , I guess there are plenty of errors to fix. Feel free to open a PR for the version bump and someone can pick it up and fix the errors. I'll then close this one and move all the findings to the new PR. Thanks a lot, @layershifter !
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(tests): make
ts-jestcompile testsProblem:
We are not including
test/folder in our typescript compiler options so nothing under tests is compiled by TypeScript.@layershifter did some research and found out the following:
We're using a Gulp's task to run
jestand our watchers for JSON info files, #task. In the Jest's config we will see, that we're usingts-jest. So the main question whyts-jestcompiles and runs the code silently? 👎Solution:
The version bump was enough to get it working correctly:
Proposal:
I talked to @smykhailov about this as well and he suggested that we should not rely on all these custom build scripts and tools (such as
gulp/grunt) for our build. Reasons:webpackaccomplishes out of the script functionality and we only need to configure it).We should leverage more the
webpackfunctionality for setting up our build. This might be a good time to do this since we are just kicking off an effort for creating a Stardust monorepo #433Do we have any issue related to our build system approach and tooling? I can create an issue and copy these findings there.
What is your take on this, guys?
@levithomason
@kuzhelov
@miroslavstastny
@layershifter
@mnajdova
@alinais
@smykhailov