Skip to content

chore: add missing methods and use a set for it #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2020
Merged

chore: add missing methods and use a set for it #184

merged 2 commits into from
Sep 3, 2020

Conversation

mxschmitt
Copy link
Member

I went through them, let me know if you are okay with that. In my mind there is no need for now to land more methods since they are almost only CR specific.

Method not implemented: Download.createReadStream <- PR open

Method not implemented: BrowserContext.serviceWorkers <- CR specific
Method not implemented: BrowserContext.backgroundPages <- CR specific
Method not implemented: Browser.newBrowserCDPSession <- important?

Method not implemented: BrowserType.launchServer <- decided to not land this in RPC clients. By that also the following methods

Method not implemented: BrowserServer.close
Method not implemented: BrowserServer.process
Method not implemented: BrowserServer.kill
Method not implemented: BrowserServer.wsEndpoint

Method not implemented: BrowserContext.newCDPSession <- its there but on the CR browser context
Method not implemented: Logger.isEnabled
Method not implemented: Logger.log
Method not implemented: Browser.stopTracing
Method not implemented: Browser.startTracing
Method not implemented: Page.coverage <- CR only
Method not implemented: Coverage.stopCSSCoverage
Method not implemented: Coverage.startCSSCoverage
Method not implemented: Coverage.startJSCoverage
Method not implemented: Coverage.stopJSCoverage
Method not implemented: BrowserContext.setHTTPCredentials <- deprecated

@pavelfeldman
Copy link
Member

Agreed that the state we are in is acceptable. Let's add these into the "expected mismatches" list and fail when there is something new?

@mxschmitt mxschmitt force-pushed the bugfix/add-missing-methods branch from d26ae22 to 2b30b9f Compare September 3, 2020 15:02
@mxschmitt mxschmitt merged commit f5f9614 into microsoft:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxschmitt @pavelfeldman