Skip to content

fix: screenshot Errors if path without file extension is provided with specifying type #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: screenshot Errors if path without file extension is provided with specifying type #2966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44e99a7
Default to png file type for screenshots if type is not provided and …
Sep 4, 2025
3bc8038
Add test for type ag without extension in path.
Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playwright/_impl/_element_handle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ def convert_select_option_values(

def determine_screenshot_type(path: Union[str, Path]) -> Literal["jpeg", "png"]:
mime_type, _ = mimetypes.guess_type(path)
if mime_type == "image/png":
if mime_type == "image/png" or mime_type is None:
return "png"
if mime_type == "image/jpeg":
return "jpeg"
Expand Down
8 changes: 8 additions & 0 deletions tests/async/test_screenshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ async def test_should_infer_screenshot_type_from_path(
await page.screenshot(path=output_jpg_file)
assert_image_file_format(output_jpg_file, "JPEG")

output_png_file = tmp_path / "foo"
await page.screenshot(path=output_png_file)
assert_image_file_format(output_png_file, "PNG")


async def test_should_screenshot_with_type_argument(page: Page, tmp_path: Path) -> None:
output_jpeg_with_png_extension = tmp_path / "foo_jpeg.png"
Expand All @@ -77,3 +81,7 @@ async def test_should_screenshot_with_type_argument(page: Page, tmp_path: Path)
output_png_with_jpeg_extension = tmp_path / "bar_png.jpeg"
await page.screenshot(path=output_png_with_jpeg_extension, type="png")
assert_image_file_format(output_png_with_jpeg_extension, "PNG")

output_png_with_jpeg_extension = tmp_path / "bar_jpeg"
await page.screenshot(path=output_png_with_jpeg_extension, type="jpeg")
assert_image_file_format(output_png_with_jpeg_extension, "JPEG")