[ci] adding github action (closes #156) #159
Conversation
|
this is still testing via circle. actions only start executing after they have at least been added to master. so if it works for you, merge this in and then the action will fire. after that PRs should do the right thing. |
Dockerfile
Outdated
| @@ -9,6 +10,8 @@ | |||
|
|
|||
| FROM neurodebian:stretch-non-free | |||
|
|
|||
| USER root | |||
There was a problem hiding this comment.
isn't the user originally root by default?
| branches: [ master ] | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
There was a problem hiding this comment.
| schedule: | |
| - cron: "0 10 * * *" | |
Co-authored-by: Mathias Goncalves <goncalves.mathias@gmail.com>
Co-authored-by: Mathias Goncalves <goncalves.mathias@gmail.com>
Co-authored-by: Mathias Goncalves <goncalves.mathias@gmail.com>
…in the GA testing workflow
|
a fun fact - the current version of the |
|
@djarecka it looks like the problem lies within the test script: nipype_tutorial/test_notebooks.py Lines 94 to 96 in ff7c423 since the return value of the system call is not checked, any command would pass. |
|
@mgxd - yes, I noticed... Will fix this later, and than would have to review the notebooks that are failing, don't even want to know when they started failing.... |
|
actually, I might just merge this first to have at least working CI structure (i will give up on finding out why CircleCI doesn't want to build the image for me) |
|
@satra - you were right, it works now! :) |
@mgxd, @effigies @satra - testing github actions, happy to get any feedback (especially if you have better idea how to deal with container management/caching)
and I'd really want to know how to enable it... when I was testing on my profile I haven't had to do anything extra, it just worked when i included .github/workflows, but here it doesn't (at least for this pr)
this is a ga dashboard from my fork (tests are failing right now):
https://github.com/djarecka/nipype_tutorial/runs/957128296?check_suite_focus=true
EDIT
general comments / for future consideration
uses: satackey/action-docker-layer-caching@v0.0.5for now (didn't check if pull/push from dockerhub is not faster). I'm assuming at some point this will be better supported and we will want to change it