Fix/get prompt description #640
Draft
+322
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; added async test and lint cleanup
felixweinberger
requested changes
Jul 14, 2025
There was a problem hiding this comment.
Thank you for your contribution! Apologies for the time it took to get a review.
I read through the description, but I'm not sure how this change affects anything related to get_prompt - the only code change seems to be a single line in server.py:
self.settings: Settings
Which I believe is redundant given it's set right below. Also I believe there are a lot of test / workflow / unrelated changes in this PR.
Would you mind cleaning this up and pushing an update if this is still an issue for you?
| @@ -132,6 +132,7 @@ def __init__( | |||
| | None = None, | |||
| **settings: Any, | |||
| ): | |||
| self.settings: Settings | |||
There was a problem hiding this comment.
I believe this is redundant given the line below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue with get_prompt() not returning the correct description. The function was modified to ensure the prompt description is correctly fetched and returned.
Motivation and Context
Why is this change needed?
The get_prompt() method was not properly retrieving the description associated with the prompt. This change fixes that behavior, ensuring that the description is returned as expected.
What problem does it solve?
This resolves the issue where the description for certain prompts was missing or not properly accessible.
How Has This Been Tested?
Yes, I tested the get_prompt() method locally using unit tests to ensure that the description is returned correctly.
I also ran the existing tests in test_prompts.py to confirm that no other functionality was broken.
Breaking Changes
No breaking changes were introduced. This is a non-breaking bug fix that addresses the behavior of get_prompt().
Types of changes
Checklist
Additional context
This change only affects the behavior of get_prompt() and is tested with the current version of the codebase. If any further adjustments are required, we will address them based on feedback.