-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix/get prompt description #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Vinisha-projects
wants to merge
16
commits into
modelcontextprotocol:main
Choose a base branch
from
Vinisha-projects:fix/get-prompt-description
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix/get prompt description #640
Vinisha-projects
wants to merge
16
commits into
modelcontextprotocol:main
from
Vinisha-projects:fix/get-prompt-description
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; added async test and lint cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue with get_prompt() not returning the correct description. The function was modified to ensure the prompt description is correctly fetched and returned.
Motivation and Context
Why is this change needed?
The get_prompt() method was not properly retrieving the description associated with the prompt. This change fixes that behavior, ensuring that the description is returned as expected.
What problem does it solve?
This resolves the issue where the description for certain prompts was missing or not properly accessible.
How Has This Been Tested?
Yes, I tested the get_prompt() method locally using unit tests to ensure that the description is returned correctly.
I also ran the existing tests in test_prompts.py to confirm that no other functionality was broken.
Breaking Changes
No breaking changes were introduced. This is a non-breaking bug fix that addresses the behavior of get_prompt().
Types of changes
Checklist
Additional context
This change only affects the behavior of get_prompt() and is tested with the current version of the codebase. If any further adjustments are required, we will address them based on feedback.