Skip to content

Types of navigateTo is missing the property 'frame' #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tuliodiaz opened this issue Nov 21, 2019 · 4 comments
Closed

Types of navigateTo is missing the property 'frame' #587

tuliodiaz opened this issue Nov 21, 2019 · 4 comments
Labels
enhancement good first issue help wanted priority:normal

Comments

@tuliodiaz
Copy link

tuliodiaz commented Nov 21, 2019 •
edited
Loading

Version

2.4.0

Reproduction link

https://github.com/nativescript-vue/nativescript-vue/blob/master/index.d.ts

Platform and OS info

All platforms

Steps to reproduce

See definition of navigateTo property options in -> https://github.com/nativescript-vue/nativescript-vue/blob/master/index.d.ts

frame is NOT defined in options

see docs -> https://nativescript-vue.org/en/docs/routing/manual-routing/#navigating-within-a-frame

What is expected?

navigateTo accept frame as part of the options

What is actually happening?

typescript is alerting me frame is not existing in options
@tuliodiaz tuliodiaz changed the title navigateTo types is missing frame property Types of navigateTo is missing frame property Nov 21, 2019
@tuliodiaz tuliodiaz changed the title Types of navigateTo is missing frame property Types of navigateTo is missing the property 'frame' Nov 21, 2019
@tarunama tarunama mentioned this issue Jan 10, 2020
Merged
@koraykupe
Copy link

I randomly get this error when using navigateTo:
undefined is not an object (evaluating 'frame.navigate)
May it be related to that?

@tarunama
Copy link
Contributor

@tuliodiaz
Issue is already fixed. Could you close this ?

@rigor789
Copy link
Member

Fixed in 2.5.0.

@nativescript-vue-bot
Copy link
Collaborator

We are locking this issue because it has been closed for more than 14 days.

If the issue comes up again please open a new issue with additional details.

@nativescript-vue nativescript-vue locked as resolved and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement good first issue help wanted priority:normal
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rigor789 @koraykupe @tarunama @tuliodiaz @nativescript-vue-bot