Fix/update type definitions #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @acidbiscuit! Thanks for the PR! I'm merging the changes, but I'm will not be able to push a release at the moment. |
khawarizmus
added a commit
to khawarizmus/nativescript-vue
that referenced
this pull request
Jan 27, 2019
updated to the latest master changes
rigor789
pushed a commit
that referenced
this pull request
Mar 18, 2019
* add registerElement to NativeScriptVueConstructor Fix: `property 'registerElement' does not exist on type 'NativeScriptVueConstructor'.` Currently, the function type is defined but was not included in the constructor. * updated in contrast to #409 updated to the latest master changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
navigateToacceptspropsproperty to pass props to navigated component, though type definitions ofNavigationEntrydo not describe such option. As instead, it suggests to pass properties viacontext.propsData, which is redundant.In addition, usage of valid way to pass
propswill cause linting issues, due to mismatching type definition.Fixed type for
NavigationEntryby extending it withpropsfield.Also, removed unused type import
Size.