Skip to content

add registerElement to NativeScriptVueConstructor #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2019

Conversation

khawarizmus
Copy link
Contributor

Fix: property 'registerElement' does not exist on type 'NativeScriptVueConstructor'.

Currently, the function type is defined but was not included in the constructor.

Fix:  `property 'registerElement' does not exist on type 'NativeScriptVueConstructor'.`

Currently, the function type is defined but was not included in the constructor.
index.d.ts Outdated
import { View } from 'tns-core-modules/ui/core/view'

export interface NavigationEntryVue extends NavigationEntry {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your branch looks to be out of date, as you've removed changes to add the enhanced type NavigationEntryVue which was added to address this issue: #409

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the pr, please review @jjstrat3

updated to the latest master changes
@jjstrat3
Copy link

I guess only @rigor789 has merge privileges?

@khawarizmus
Copy link
Contributor Author

@rigor789 any heads up on this?

@rigor789 rigor789 merged commit 7adad31 into nativescript-vue:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants