Skip to content

Rework layout docs #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 30, 2018
Merged

Rework layout docs #164

merged 18 commits into from
Jul 30, 2018

Conversation

ikoevska
Copy link
Contributor

WIP, reworking layout docs. @rigor789 can you supply/set up an image for the dock to center sample in DockLayout?

@nativescript-vue-bot
Copy link

nativescript-vue-bot commented Jun 25, 2018

Deploy preview for nativescript-vue ready!

Built with commit 8cb5f37

https://deploy-preview-164--nativescript-vue.netlify.com

@rigor789
Copy link
Member

@ikoevska can you sketch it out so I know what it needs to look like? (a freehand sketch or anything will work)

@ikoevska
Copy link
Contributor Author

On my phone, it looks like this:

36188993_10156374330950890_6466497533882400768_n

@rigor789
Copy link
Member

@ikoevska thanks! I'll get to it in a bit

@rigor789
Copy link
Member

@ikoevska ikoevska changed the title [WIP] Rework layout docs Rework layout docs Jul 30, 2018
@ikoevska
Copy link
Contributor Author

Finally done with this one. @rigor789 can you take a look? Basically, I've:

  • reworded most of it
  • added example descriptions everywhere

@rigor789
Copy link
Member

@ikoevska looks good, thanks!

@rigor789 rigor789 merged commit fecc8e6 into nativescript-vue:master Jul 30, 2018
@ikoevska ikoevska deleted the wip-june-25 branch July 31, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants